Skip to content
/ rfcs Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0075] Declarative wrappers #75

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ef81400
[RFC 55]: Declarative Wrappers
doronbehar May 10, 2020
b780229
Declarative wrappers
doronbehar Aug 15, 2020
d09a058
Finish motivation
doronbehar Aug 16, 2020
37c7a8c
Remove old RFC file
doronbehar Aug 16, 2020
2a0a630
Add more relevant issues regarding compiling wrappers
doronbehar Aug 16, 2020
c9d7055
Write most of the design and more
doronbehar Aug 16, 2020
abb7609
Small improvements to summary vs motivation
doronbehar Aug 16, 2020
d1cadb6
Rephrase a bit orchestrating motivation section
doronbehar Aug 16, 2020
a570b1a
Add small ()
doronbehar Aug 16, 2020
8db3605
More rephrasings and additions
doronbehar Aug 16, 2020
5ddd60b
Fix possibly fixable title
doronbehar Aug 16, 2020
778bc99
Design sec improvements
doronbehar Aug 16, 2020
44a3b87
Improve examples
doronbehar Aug 16, 2020
0b259fa
Improve ending
doronbehar Aug 16, 2020
d75c73e
Last (?) rephrasings
doronbehar Aug 16, 2020
94038bd
75: Introduction on run-time dependencies and wrappers.
FRidh Aug 20, 2020
0fa64ab
Merge pull request #1 from FRidh/75-intro
doronbehar Aug 25, 2020
ffacf5f
Add SANE_CONFIG_DIR issue to motivation
doronbehar Aug 30, 2020
f754ad7
Mark @nmattia's idea as unsuitable because of IFD.
doronbehar Sep 8, 2020
4ab0448
Revert "Mark @nmattia's idea as unsuitable because of IFD."
doronbehar Sep 11, 2020
60d3825
Add shepherds
edolstra Nov 19, 2020
f3416a0
Remove out scope Nixpkgs issue #32790 from motivation
doronbehar Feb 24, 2021
c092848
Add date to header
doronbehar Feb 24, 2021
732246d
Mention a new hplip wrapping issue
doronbehar Feb 24, 2021
67b002b
Update link to gnome docs
doronbehar Feb 24, 2021
cac0cbb
Better explain Nixpkgs issue #86369
doronbehar Feb 24, 2021
7b0c9e1
Remove some not directly related issues to wrapping
doronbehar Feb 24, 2021
034a13e
Rewrite most of RFC after 1st meeting
doronbehar Feb 24, 2021
edbf315
Small rephrasings
doronbehar Mar 19, 2021
48f9118
Add shepherd leader metadata
lheckemann Jun 10, 2021
73421fd
Apply suggestions by @lheckermann
doronbehar Jul 18, 2021
f0c2533
Rename wrappersInfo -> combineWrappersInfo
doronbehar Jul 18, 2021
391f5d0
Add subtitles for the motivation categories
doronbehar Jul 18, 2021
fb0dd98
Small rephrasings
doronbehar Aug 6, 2021
c51c9c0
Use a list of glob patterns for the wrapping
doronbehar Aug 6, 2021
31a24a0
Small rephrasings
doronbehar Aug 14, 2021
a6123b9
Explain default behaviour of order and separators
doronbehar Aug 14, 2021
a65ac77
Make combineWrappersInfo a nix function that returns a shell command
doronbehar Aug 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mention a new hplip wrapping issue
doronbehar committed Feb 24, 2021
commit 732246db26abd0be1994668f41b25eca6e10d7f9
1 change: 1 addition & 0 deletions rfcs/0075-declarative-wrappers.md
Original file line number Diff line number Diff line change
@@ -92,6 +92,7 @@ and
`git-remote-hg` and `qttools` are not wrapped properly.

- [issue 86048](https://github.com/NixOS/nixpkgs/issues/86048)
- [issue 114051](https://github.com/NixOS/nixpkgs/issues/114051)

I guess we don't wrap HPLIP because not everybody want to use these binaries
and hence want these GUI deps in their closure (if they were wrapped with a