Add check for lib tests #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, a big part of the lib tests aren't being done, which previously lead to e.g. NixOS/nixpkgs#76861 And this will also be useful for checked maintainers in NixOS/nixpkgs#82461
1 task
|
This looks really useful. @grahamc who is able to review/merge things here? Would be nice to see our CI evolve into checking more tings like outlined here. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, a big part of the lib tests aren't being done, which
previously lead to e.g. NixOS/nixpkgs#76861
And this will also be useful for checked maintainers in NixOS/nixpkgs#82461
I have not tested this code in any way