Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guvcview: fix gsettings filechooser errors #84449

Merged
merged 9 commits into from
Apr 28, 2020
Merged

guvcview: fix gsettings filechooser errors #84449

merged 9 commits into from
Apr 28, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 6, 2020 •
edited
Loading

Motivation for this change

Fix this error:

(guvcview:8975): GLib-GIO-ERROR **: 10:38:24.106: Settings schema 'org.gtk.Settings.FileChooser' is not installed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 6, 2020
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Apr 6, 2020
@grahamc
Copy link
Member

grahamc commented Apr 6, 2020

@GrahamcOfBorg eval

@grahamc grahamc removed the ofborg-internal-error Ofborg encountered an error label Apr 6, 2020
symphorien
symphorien approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nix-review, and checked that the file dialog in guvcview works. If you feel brave, qstopmotion (a reverse dependency) is in need of wrapQTappsHook.

@doronbehar
Copy link
Contributor Author

I ran nix-review, and checked that the file dialog in guvcview works. If you feel brave, qstopmotion (a reverse dependency) is in need of wrapQTappsHook.

Nice thinking. Is there an open issue you've encountered regarding this?

The next set of commits introduces a little bit broader changes which I think would be appropriate under the approval of @leenaars - maintainer of qstopmotion, and @coreyoconnor - maintainer of guvcview. Let's hope they'll respond.

worldofpeace
worldofpeace suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In qstopmotion you should instead use the qt specific deriver mkDerivation, which automatically adds the hook.

@doronbehar
Copy link
Contributor Author

@worldofpeace I used qt5.mkDerivation I hope that's what you meant.

@doronbehar doronbehar requested a review from worldofpeace April 7, 2020 12:51
@doronbehar doronbehar mentioned this pull request Apr 7, 2020
Open
@symphorien
Copy link
Member

I built guvcview and qstopmotion with nix-review and they both seem to work (as in, a window shows up).

This was referenced Apr 11, 2020
Closed
Closed
@doronbehar
Copy link
Contributor Author

/ping @worldofpeace .

@doronbehar doronbehar requested a review from worldofpeace April 23, 2020 15:31
@doronbehar
Copy link
Contributor Author

doronbehar commented Apr 25, 2020 •
edited
Loading

/ping @worldofpeace 🙏

@worldofpeace
Copy link
Contributor

/ping @worldofpeace pray

Very close 😄 I can try to merge today.

@doronbehar
Copy link
Contributor Author

@worldofpeace most of ofborg's tests have passed besides the build of qstopmotion for Linux aarch64 for which I marked it as broken.

@doronbehar doronbehar requested a review from worldofpeace April 28, 2020 07:56
@doronbehar
Copy link
Contributor Author

👏 @worldofpeace 🙏.

@worldofpeace worldofpeace merged commit d85aabf into NixOS:master Apr 28, 2020
@worldofpeace
Copy link
Contributor

@doronbehar Was this an issue on 20.03?

@doronbehar
Copy link
Contributor Author

Thanks :]

@doronbehar Was this an issue on 20.03?

I'm using unstable so I don't know.

@mkf mkf mentioned this pull request Nov 23, 2020
Closed
@doronbehar doronbehar deleted the improve-guvcview branch March 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doronbehar @grahamc @symphorien @worldofpeace