Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-file-transfer: fix building with qt #65676

Merged
merged 1 commit into from
Jul 31, 2019
Merged

android-file-transfer: fix building with qt #65676

merged 1 commit into from
Jul 31, 2019

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Jul 31, 2019

Motivation for this change

Import mkDerivation instead of using stdenv.mkDerivation (see #54525).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh
android-file-transfer: fix building with qt
064ddec 
Use mkDerivation has instead of stdenv.mkDerivation (see NixOS#54525).
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 31, 2019
@xaverdh
Copy link
Contributor Author

xaverdh commented Jul 31, 2019

The relevant issue is here #65399

@dywedir
Copy link
Member

dywedir commented Jul 31, 2019

@GrahamcOfBorg build android-file-transfer

@dywedir dywedir merged commit 06183c2 into NixOS:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaverdh @dywedir