mirakurun: init at 3.3.0

[midchildan]

Motivation for this change

Mirakurun is a backend for DVR software that manages ISDB-compatible tuners.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[midchildan]

I rebased and ran ./generate.sh.

[midchildan]

Looks like v4l-utils is currently broken in master.

[midchildan]

Rebased again to pull in v4l-utils fixes so that the build would pass again.

[infinisil]

Haven't had the motivation for full module reviews recently, I hope you don't mind this being a bit late!

[midchildan]

Haven't had the motivation for full module reviews recently, I hope you don't mind this being a bit late!

No worries, your reviews are helpful and I've learned quite a lot :-)

[infinisil]

Looking good! Can you squash the commits into at least one for the package and one for the module?

[midchildan]

I'm going to put the braces back on where lib.optionals are used. It seems the current implementation doesn't always return a list.

nixpkgs/lib/lists.nix

Lines 266 to 270 in d4bbe9a

	optionals =
	# Condition
	cond:
	# List to return if condition is true
	elems: if cond then elems else [];

Here's the error message from the module:

while evaluating the attribute 'value' at /home/midchildan/Documents/src/repos/github.com/NixOS/nixpkgs/lib/modules.nix:281:44:
value is a string while a list was expected, at /home/midchildan/Documents/src/repos/github.com/NixOS/nixpkgs/nixos/modules/services/video/mirakurun.nix:148:16

[midchildan]

Done

diff --git a/nixos/modules/services/video/mirakurun.nix b/nixos/modules/services/video/mirakurun.nix
index e878802db7c..ec45bd84184 100644
--- a/nixos/modules/services/video/mirakurun.nix
+++ b/nixos/modules/services/video/mirakurun.nix
@@ -145,8 +145,8 @@ in
           getconf = target: config.environment.etc."mirakurun/${target}.yml".source;
           targets = [
             "server"
-          ] ++ optionals (cfg.tunerSettings != null) "tuners"
-            ++ optionals (cfg.channelSettings != null) "channels";
+          ] ++ optionals (cfg.tunerSettings != null) [ "tuners" ]
+            ++ optionals (cfg.channelSettings != null) [ "channels" ];
         in (map getconf targets);
       };
     };

[midchildan]

Thanks! Would you also mind to take a look at #49413?