alloy: add alloy5 and take maintainership #47262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add alloy5 (currently, 5.0.0.1), update homepage and downloadPage, and take maintainership of the package.
GrahamcOfBorg
added
8.has: package (new)
Mic92
reviewed
Sep 24, 2018
| install -Dm644 ${./icon.png} $out/share/pixmaps/alloy.png | ||
| cp -r ${desktopItem}/share/applications $out/share | ||
| ''; | ||
| install -Dm755 ${nameMajor} $out/bin/${nameMajor} |
There was a problem hiding this comment.
Use makeWrapper here as described in the java chapter of the nixpkgs manual.
There was a problem hiding this comment.
makeWrapper goes to nativeBuildInputs
|
|
||
| installPhase = '' | ||
| jar=$out/share/alloy/alloy${version}.jar | ||
| phases = [ "installPhase" ]; |
There was a problem hiding this comment.
I would rather not override these phases as it gives users to apply custom modifications when overriding the package.
|
|
||
| phases = [ "installPhase" ]; | ||
| buildInputs = [ jre ]; |
There was a problem hiding this comment.
Not really used for building. In the wrapper the full path is specified already.
|
Please remember to remove alloy4, once alloy5 becomes the stable version. |
|
@Mic92 Thanks for the feedback, I pushed another commit. And yeah I'll remove version 4 once 5 is stable. |
|
Thanks for packaging this! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alloy5 (currently, 5.0.0.1), update homepage and downloadPage, and
take maintainership of the package.
Motivation for this change
I've started using
alloyfor my research, and noticed that the package was orphaned a while ago, and that alloy 5 wasn't available on nixpkgs. So I thought I'd change that 🙂Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)This is my first ever contribution to nixpkgs, please feel free to point out any mistakes and/or areas of improvement.