Convert maintainer file entries to attributes, add github handles #36119

Profpatsch · 2018-02-28T14:24:44Z

Based on #34842, the
nix-instantiate output was pretty-printed and the validity of the github handles
manually verified, by automatically checking whether the user handles exist on
github (https://github.com/userhandle, status 200 or 404).
Each handle under 5 characters was manually checked (because the collision
probability with non-maintainer accounts is high), each missing entry was
manually researched.

The script used is kept in maintainers/scripts as an example of how to work
with the mainainers list through nix’ JSON interface.

Hydra might need to be patched.

cc @FRidh @vcunat

FRidh · 2018-02-28T14:33:57Z

Thanks for the effort. Note the merge conflict though.

cillianderoiste · 2018-02-28T14:37:00Z

lib/maintainers.nix

+  };
+  dizfer = {
+    email = "[email protected]";
+    githu


My github id is cillianderoiste, thanks!

Thanks, fixed.

Profpatsch · 2018-02-28T14:48:16Z

Note the merge conflict though.

Yeah, I expect this to take a while to merge, so there might be multiple changes to maintainers nix by then.

FRidh · 2018-02-28T14:55:33Z

Right. That's why I suggested merging #34842 first, then fixing Hydra, and when that is done convert to what you have here.

jtojnar · 2018-02-28T14:57:46Z

lib/maintainers.nix

+  };
+  dizfer = {
+    email = "[email protected]";
+    githu


Should be @gavinrogers, see #35714

Something is broken with these markers, every one points to dizfer somehow?

gavin → gavinrogers

jtojnar · 2018-02-28T14:58:50Z

lib/maintainers.nix

+  };
+  dizfer = {
+    email = "[email protected]";
+    githu


genesis → bignaux

jtojnar · 2018-02-28T15:00:03Z

lib/maintainers.nix

+  };
+  dizfer = {
+    email = "[email protected]";
+    githu


eelco → edolstra

Profpatsch · 2018-02-28T15:42:20Z

It looks like cross-checking entries <5 chars is not enough, normal dictionary words will most likely also overlap.

Profpatsch · 2018-02-28T15:55:04Z

That's why I suggested merging #34842 first

The problem with that commit is that lots of github handles are simply wrong, because the maintainer names don’t translate. So we are going to mention lots of non-nixos people.

jtojnar · 2018-02-28T16:03:52Z

How hard would it be to check if given handle contributed to the nixpkgs repo and (manually) fix those that did not?

Edit: There is https://github.com/NixOS/nixpkgs/commits?author=ttuegel

7c6f434c · 2018-02-28T16:29:57Z

Well, may vanity counter does build a correspondence of names, emails and github names

7c6f434c · 2018-02-28T16:31:03Z

lib/maintainers.nix

+  };
+  dizfer = {
+    email = "[email protected]";
+    githu


That's actually me, 7c6f434c

raskin → 7c6f434c

GitHub is really weird today.

Profpatsch · 2018-02-28T17:38:50Z

How hard would it be to check if given handle contributed to the nixpkgs repo and (manually) fix those that did not?

Probably not very, might be sensible to use the Github API for that and rewrite the script (in the commit) a bit.

jtojnar · 2018-02-28T17:42:59Z

curl "https://github.com/NixOS/nixpkgs/commits?author=${user}" | grep 'No commits found' should be good enough.

Profpatsch · 2018-03-03T02:56:13Z

Checking for commits right now, this finds quite a few accounts that are not commiters. curling the github repo is pretty slow, since github has very hard limits on the amount of requests possible (and returns HTTP 429 in that case).

Profpatsch · 2018-03-03T05:38:11Z

Okay, here we go. Now every handle that had no nixpkgs commits is corrected!

Profpatsch · 2018-03-03T20:01:59Z

Thanks to @aszlig’s input, I added a shortName property, which is used by hydra to send mails. @FRidh this should supersede #34842, minus the need for parsing.

Profpatsch · 2018-03-03T21:22:27Z

Removed the shortName again, @grahamc said we should fix hydra instead. According to @aszlig’s and my research, this will only lead to hydra not sending any mails for the time being.

oxij · 2018-03-03T22:13:48Z

Yay, nice! Can we also rename this file to `maintainers/maintainers-list.nix` while we at this? Motivation: much saner `git log ./lib`. I wanted to do it for a while now, but was too lazy to make a separate PR for that.

jtojnar

Maybe also run curl "https://github.com/NixOS/nixpkgs/pulls?utf8=%E2%9C%93&q=author%3A${user}" | grep 'No results matched your search' for users that commit without matching e-mail address.

jtojnar · 2018-03-03T22:51:30Z

lib/maintainers.nix

@@ -1319,7 +1313,6 @@
  };
  fuzzy-id = {
    email = "[email protected]";
-    github = "fuzzy-id";


jtojnar · 2018-03-03T22:52:21Z

lib/maintainers.nix

@@ -1150,7 +1145,6 @@
  };
  epitrochoid = {
    email = "[email protected]";
-    github = "epitrochoid";


jtojnar · 2018-03-03T22:54:50Z

lib/maintainers.nix

@@ -1020,7 +1017,6 @@
  };
  drewkett = {
    email = "[email protected]";
-    github = "drewkett";


Based on NixOS#34842, the nix-instantiate output was pretty-printed and the validity of the github handles manually verified, by automatically checking whether the user handles exist on github (https://github.com/userhandle, status 200 or 404). Each handle under 5 characters was manually checked (because the collision probability with non-maintainer accounts is high), each missing entry was manually researched. The script used is kept in `maintainers/scripts` as an example of how to work with the mainainers list through nix’ JSON interface.

Now also finds name-clashes for github handles who never contributed to nixpkgs before. Also deals with too many request errors.

Corrected every handle that had no commits to nixpkgs, manually researched the correct handles by looking at maintained packages & blames/history on Github.

Add new maintainers that were added before merging the new `maintainers.nix` file format.

Profpatsch · 2018-03-04T02:12:06Z

@jtojnar I don’t understand, why is this a problem?

oxij · 2018-03-04T03:14:36Z

See #36275.

Profpatsch · 2018-03-04T03:32:47Z

@GrahamcOfBorg eval

jtojnar · 2018-03-04T04:06:08Z

@Profpatsch the problem is, you are removing GitHub handles that have commits in nixpkgs (but GitHub cannot pair them).

Profpatsch · 2018-03-04T04:17:03Z

I removed every handle where Github couldn’t resolve to a user page, yes, since those are either commits from non-Github users (via normal git commits) or Github accounts that don’t exist anymore.

jtojnar · 2018-03-04T04:33:28Z

At least the three I mentioned do resolve to a user page, are commits by GitHub users, and the accounts do still exist, only GitHub cannot pair them correctly (due to e-mail address mismatch). Checking the pull requests should fix these unpaired accounts.

Then only renamed accounts will remain. They need to be checked manually by checking the git log for expressions by the maintainer.

Profpatsch · 2018-03-04T04:40:49Z

Ah, I see. Can you open a new issue (or maybe even pull request) for those cases? Thanks for the scrutiny!

Many commits unrelated to `lib` touch that file, this will make `git log ./lib` much saner. This is what I meant in NixOS#36119 (comment).

Was inconveniently sorted since NixOS#36119

Profpatsch requested review from edolstra and nbp as code owners February 28, 2018 14:24

cillianderoiste reviewed Feb 28, 2018

View reviewed changes

Profpatsch force-pushed the maintainer-reformat branch from 03c6ac3 to cb09e44 Compare February 28, 2018 14:44

jtojnar reviewed Feb 28, 2018

View reviewed changes

7c6f434c reviewed Feb 28, 2018

View reviewed changes

Profpatsch force-pushed the maintainer-reformat branch from cbfe828 to 53df522 Compare March 3, 2018 15:50

Profpatsch force-pushed the maintainer-reformat branch 2 times, most recently from 08f2720 to 53df522 Compare March 3, 2018 21:20

jtojnar requested changes Mar 3, 2018

View reviewed changes

Profpatsch added 4 commits March 4, 2018 03:08

maintainers/scripts: improve github handle checker

cdf9ec2

Now also finds name-clashes for github handles who never contributed to nixpkgs before. Also deals with too many request errors.

lib/maintainers: correct wrong (clashing) github handles

5b7021d

Corrected every handle that had no commits to nixpkgs, manually researched the correct handles by looking at maintained packages & blames/history on Github.

lib/maintainers: add new maintainers before maintainers merge

050abd0

Add new maintainers that were added before merging the new `maintainers.nix` file format.

Profpatsch force-pushed the maintainer-reformat branch from 53df522 to 050abd0 Compare March 4, 2018 02:09

Profpatsch mentioned this pull request Mar 4, 2018

lib.maintainers: maintainer is now a set #34842

Closed

8 tasks

grahamc mentioned this pull request Mar 4, 2018

Revert "Convert maintainer file entries to attributes, add github handles" #36278

Merged

Profpatsch mentioned this pull request Mar 4, 2018

Every maintainer now has a Github handle! nix-community/nixpkgs-update#4

Closed

fpletz mentioned this pull request Mar 4, 2018

@handle in lib/maintainers.nix must be a github username #18352

Closed

oxij added a commit to oxij/nixpkgs that referenced this pull request Mar 6, 2018

stdenv: check-meta: fix fallout from NixOS#36119

1d4f3fa

FRidh mentioned this pull request Mar 18, 2018

Ping meta.maintainers NixOS/ofborg#70

Closed

Profpatsch mentioned this pull request Mar 31, 2018

Fully automate nix-update nix-community/nixpkgs-update#13

Closed

4 tasks

infinisil added a commit to infinisil/nixpkgs that referenced this pull request Jul 11, 2018

maintainer-list: sort and format

e5e5ce5

Was inconveniently sorted since NixOS#36119

infinisil mentioned this pull request Jul 11, 2018

maintainer-list: sort and format #43311

Merged

eadwu pushed a commit to eadwu/nixpkgs that referenced this pull request Jul 11, 2018

maintainer-list: sort and format

2204598

Was inconveniently sorted since NixOS#36119

jtojnar mentioned this pull request Oct 27, 2019

lib: Add lib.maintainer-groups #72125

Merged

infinisil mentioned this pull request Mar 15, 2020

Checked maintainers #82461

Merged

1 task

Convert maintainer file entries to attributes, add github handles #36119

Convert maintainer file entries to attributes, add github handles #36119

Conversation

Profpatsch commented Feb 28, 2018 • edited Loading

FRidh commented Feb 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Profpatsch commented Feb 28, 2018

FRidh commented Feb 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar Feb 28, 2018 • edited Loading

Choose a reason for hiding this comment

Profpatsch commented Feb 28, 2018

Profpatsch commented Feb 28, 2018

jtojnar commented Feb 28, 2018 • edited Loading

7c6f434c commented Feb 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Profpatsch commented Feb 28, 2018

jtojnar commented Feb 28, 2018 • edited Loading

Profpatsch commented Mar 3, 2018

Profpatsch commented Mar 3, 2018

Profpatsch commented Mar 3, 2018

Profpatsch commented Mar 3, 2018

oxij commented Mar 3, 2018 via email

jtojnar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Profpatsch commented Mar 4, 2018

oxij commented Mar 4, 2018

Profpatsch commented Mar 4, 2018

jtojnar commented Mar 4, 2018

Profpatsch commented Mar 4, 2018

jtojnar commented Mar 4, 2018

Profpatsch commented Mar 4, 2018

Profpatsch commented Feb 28, 2018 •

edited

Loading

jtojnar Feb 28, 2018 •

edited

Loading

jtojnar commented Feb 28, 2018 •

edited

Loading

jtojnar commented Feb 28, 2018 •

edited

Loading