various: replace substituteAll with replaceVars #360770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: qt/kde
6.topic: emacs
nix-owners
bot
requested review from
adisbladis,
alyssais,
AndersonTorres,
corngood,
dtzWill,
Ericson2314,
jian-lin,
K900,
lovek323,
matthewbauer,
NickCao,
philiptaron,
roberth,
RossComputerGuy and
rrbutani
This deals with some special cases, i.e. where "null" is used to avoid replacing some values or where the syntax is not too easy to grep for for automated replacement.
wolfgangwalther
force-pushed
the
substitute-all-replace-vars-staging
branch
from
ea0ada2 to
4423b07
Compare
philiptaron
approved these changes
Dec 2, 2024
ofborg
bot
added
10.rebuild-darwin-stdenv
|
ack |
is this a positive (acknowledged?) or a negative (choking sound?)? |
|
This is "acknowledged", yes. |
|
I built each of these changes and they all go through. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working my way towards removing substituteAll in #237216.
This deals with some special cases, which can't be auto-replaced easily. My goal is to deal with all special cases first, and then replace the remaining ones in one go.
Part of my overall effort for structuredAttrs in #205690.
@philiptaron @emilazy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.