ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 #354396

Bot-wxt1221 · 2024-11-08T04:29:28Z

Things done

ZHF: #352882

Add a 👍 reaction to pull requests you find important.

stepbrobd · 2024-11-08T23:39:35Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354396

`aarch64-darwin`

❌ 1 package failed to build:

livepeer

✅ 7 packages built:

ffmpeg-livepeer
ffmpeg-livepeer.bin
ffmpeg-livepeer.data
ffmpeg-livepeer.dev
ffmpeg-livepeer.doc
ffmpeg-livepeer.lib
ffmpeg-livepeer.man

Failed in checkPhase (btw I have sandbox enabled on my machine):

# github.com/livepeer/lpms/ffmpeg
decoder.c:286:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
E1108 23:39:34.326309   15528 ai_http.go:472] Invalid auth type
E1108 23:39:34.327021   15528 ai_http.go:480] Invalid shared secret
E1108 23:39:34.327042   15528 handlers.go:1596] HTTP Response Error statusCode=401 err=invalid secret
E1108 23:39:34.327078   15528 ai_http.go:486] Error getting mime type mime: no media type
E1108 23:39:34.327179   15528 ai_http.go:486] Error getting mime type mime: no media type
E1108 23:39:34.327256   15528 ai_http.go:493] Could not parse task ID strconv.ParseInt: parsing "": invalid syntax
--- FAIL: TestAIWorkerResults_BadRequestType (0.00s)
panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: bind: operation not permitted [recovered]
        panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: bind: operation not permitted

goroutine 66 [running]:
testing.tRunner.func1.2({0x1056518a0, 0x140006fc230})
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/testing/testing.go:1632 +0x1bc
testing.tRunner.func1()
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/testing/testing.go:1635 +0x334
panic({0x1056518a0?, 0x140006fc230?})
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/runtime/panic.go:785 +0x124
net/http/httptest.newLocalListener()
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/net/http/httptest/server.go:71 +0xdc
net/http/httptest.NewUnstartedServer(...)
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/net/http/httptest/server.go:119
net/http/httptest.NewTLSServer({0x105987ba0, 0x140006fc1d0})
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/net/http/httptest/server.go:191 +0x28
github.com/livepeer/go-livepeer/server.TestAIWorkerResults_BadRequestType(0x14000b0dba0)
        /private/tmp/nix-build-livepeer-0.8.0.drv-0/source/server/ai_http_test.go:89 +0x168
testing.tRunner(0x14000b0dba0, 0x10597bb60)
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/testing/testing.go:1690 +0xe4
created by testing.(*T).Run in goroutine 1
        /nix/store/sc8n76lwg70fxcwnkxhqqfvfpvclqijy-go-1.23.2/share/go/src/testing/testing.go:1743 +0x314
FAIL    github.com/livepeer/go-livepeer/server  0.551s
FAIL

khaneliman · 2024-11-09T00:31:49Z

Does __darwinAllowLocalNetworking = true; resolve it?

emilazy · 2024-11-09T00:50:41Z

I do not think we should introduce yet more FFmpeg forks that will inevitably break when we update the FFmpeg derivation. The Hydra build failure looks related to FFmpeg 7.0, not 7.1, so if this is working with their FFmpeg 7.0 fork then I expect it would likely work with our FFmpeg 7.1.

stepbrobd · 2024-11-09T01:12:58Z

Does __darwinAllowLocalNetworking = true; resolve it?

The test passes after adding this

Bot-wxt1221 · 2024-11-09T04:23:05Z

@emilazy The newest livepeer need their self ffmpeg. These are patch from upstream livepeer/FFmpeg#32. Another solution is just apply patch. The function avfilter_compare_sign_bypath and so on is only available here

emilazy · 2024-11-09T08:25:21Z

~~The patches they apply to FFmpeg don’t seem too substantial. What error message do you get building with the normal FFmpeg package?~~

Sorry, missed your edit when writing this comment. Applying the patches seems better than using the fork directly, but I think it’s still quite likely to break down the line.

Bot-wxt1221 · 2024-11-09T09:14:35Z

Not test.

Atemu · 2024-11-11T02:19:56Z

Ah, I recommended it without regard for what this app is. Headed ffmpeg is only useful if you're going to be using it inside of a graphical environment where you need e.g. ffplay or x11 capture support.

Bot-wxt1221 · 2024-11-11T02:21:46Z

@Atemu So now I switch to ffmpeg-headless and can be compiled.

Atemu

Diff LGTM

@ofborg build ffmpeg-livepeer livepeer

pkgs/by-name/ff/ffmpeg-livepeer/package.nix

Bot-wxt1221 · 2024-11-11T02:44:30Z

@ofborg build livepeer ffmpeg-livepeer

Atemu · 2024-11-11T02:47:37Z

(FYI: You don't need to rebase atop of master all the time, only when there's a conflict.)

Bot-wxt1221 · 2024-11-11T06:44:16Z

@ofborg build livepeer ffmpeg-livepeer

Atemu

Otherwise LGTM.

pkgs/by-name/ff/ffmpeg-livepeer/package.nix

jopejoe1 · 2024-11-11T11:55:01Z

pkgs/by-name/ff/ffmpeg-livepeer/package.nix

+    buildInputs =
+      old.buildInputs or [ ]
+      ++ lib.optionals stdenv.hostPlatform.isDarwin [
+        apple-sdk_11
+      ];


This will becomme unnescessary after the current staging-next gets merged

The current staging-next is for 24.11, which still has the 10.12 SDK as the default on x86_64-darwin. The work to make the 11.3 SDK the default is still in progress and hasn’t been merged yet.

Oh, right. ffmpeg is using the 15.0 SDK on stanging-next. My previous reply is correct in general but not relevant for ffmpeg.

Should we remove this and let this PR target staging-next then?

I don't agree. It's now OK to merge. We should remove it when staging-next is merged.

According to release schedule (#339153) staging-next is planned to be merged into master on the 12th of November (tomorrow)

It’s probably not going to be tomorrow because of events and happenings. We started a bit late because of builders catching fire. Probably a few more days, but I think it’s fine to wait until the merge rather than adding overrideAttrs hacks.

Or, yes, just target this at staging-next directly and then we can merge it.

@emilazy Done. Now I remove apple-sdk_11.

pkgs/by-name/ff/ffmpeg-livepeer/package.nix

Atemu

@ofborg build livepeer ffmpeg-livepeer

pkgs/by-name/ff/ffmpeg-livepeer/package.nix

Atemu · 2024-11-12T05:07:57Z

@ofborg build livepeer ffmpeg-livepeer

Bot-wxt1221 marked this pull request as draft November 8, 2024 06:01

This comment was marked as resolved.

Sign in to view

Bot-wxt1221 changed the title ~~livepeer: 0.5.20 -> 0.8.0~~ [WIP] livepeer: 0.5.20 -> 0.8.0 Nov 8, 2024

ofborg bot requested a review from elitak November 8, 2024 06:57

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2024

Bot-wxt1221 force-pushed the livepeer branch from 33507a3 to 885c6e3 Compare November 8, 2024 06:59

Bot-wxt1221 changed the title ~~[WIP] livepeer: 0.5.20 -> 0.8.0~~ livepeer: 0.5.20 -> 0.8.0 Nov 8, 2024

Bot-wxt1221 marked this pull request as ready for review November 8, 2024 06:59

Bot-wxt1221 changed the title ~~livepeer: 0.5.20 -> 0.8.0~~ ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 Nov 8, 2024

Bot-wxt1221 force-pushed the livepeer branch 2 times, most recently from 80f5e82 to f1f7306 Compare November 8, 2024 07:21

Bot-wxt1221 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2024

ofborg bot added 8.has: package (new) This PR adds a new package and removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Nov 8, 2024

Bot-wxt1221 requested a review from a team November 8, 2024 23:28

Bot-wxt1221 force-pushed the livepeer branch from f1f7306 to a8e7964 Compare November 9, 2024 04:32

Bot-wxt1221 force-pushed the livepeer branch from a8e7964 to c7e5473 Compare November 9, 2024 09:13

Bot-wxt1221 marked this pull request as draft November 9, 2024 09:14

Bot-wxt1221 force-pushed the livepeer branch from c7e5473 to 8ea9979 Compare November 9, 2024 09:14

Bot-wxt1221 force-pushed the livepeer branch from d4d89b4 to a86a695 Compare November 11, 2024 01:15

Atemu approved these changes Nov 11, 2024

View reviewed changes

pkgs/by-name/ff/ffmpeg-livepeer/package.nix Show resolved Hide resolved

pkgs/by-name/ff/ffmpeg-livepeer/package.nix Show resolved Hide resolved

Bot-wxt1221 force-pushed the livepeer branch from 6e27988 to 843d749 Compare November 11, 2024 02:44

Bot-wxt1221 force-pushed the livepeer branch from 843d749 to eafb3d6 Compare November 11, 2024 06:44

Bot-wxt1221 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024

Bot-wxt1221 removed the request for review from a team November 11, 2024 08:16

Atemu approved these changes Nov 11, 2024

View reviewed changes

pkgs/by-name/ff/ffmpeg-livepeer/package.nix Outdated Show resolved Hide resolved

Bot-wxt1221 force-pushed the livepeer branch from eafb3d6 to 4e91a43 Compare November 11, 2024 09:21

jopejoe1 reviewed Nov 11, 2024

View reviewed changes

Bot-wxt1221 force-pushed the livepeer branch from 4e91a43 to 57a0bb3 Compare November 11, 2024 12:02

Bot-wxt1221 changed the base branch from master to staging-next November 11, 2024 13:39

Bot-wxt1221 force-pushed the livepeer branch 2 times, most recently from 2e67253 to e739e26 Compare November 11, 2024 13:41

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024

Atemu approved these changes Nov 12, 2024

View reviewed changes

pkgs/by-name/ff/ffmpeg-livepeer/package.nix Outdated Show resolved Hide resolved

ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Nov 12, 2024

Bot-wxt1221 force-pushed the livepeer branch from e739e26 to d3f1f24 Compare November 12, 2024 04:32

Bot-wxt1221 added 5 commits November 12, 2024 12:32

ffmpeg-livepeer: init at 7.0.1

1628b4a

livepeer: nixfmt

dd2b640

livepeer: add passthru.updateScript

bac24e8

livepeer: 0.5.20 -> 0.8.0

98b7a76

livepeer: add bot-wxt1221 as maintainers

a22d388

Bot-wxt1221 force-pushed the livepeer branch from d3f1f24 to a22d388 Compare November 12, 2024 04:33

wegank merged commit 7ae1889 into NixOS:staging-next Nov 13, 2024
30 of 32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 #354396

ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 #354396

Bot-wxt1221 commented Nov 8, 2024 •

edited

Loading

This comment was marked as resolved.

stepbrobd commented Nov 8, 2024 •

edited

Loading

khaneliman commented Nov 9, 2024

emilazy commented Nov 9, 2024

stepbrobd commented Nov 9, 2024

Bot-wxt1221 commented Nov 9, 2024 •

edited

Loading

emilazy commented Nov 9, 2024 •

edited

Loading

Bot-wxt1221 commented Nov 9, 2024

Atemu commented Nov 11, 2024

Bot-wxt1221 commented Nov 11, 2024

Atemu left a comment

Bot-wxt1221 commented Nov 11, 2024

Atemu commented Nov 11, 2024

Bot-wxt1221 commented Nov 11, 2024 •

edited

Loading

Atemu left a comment

jopejoe1 Nov 11, 2024

reckenrode Nov 11, 2024

reckenrode Nov 11, 2024 •

edited

Loading

Atemu Nov 11, 2024

Bot-wxt1221 Nov 11, 2024 •

edited

Loading

jopejoe1 Nov 11, 2024 •

edited

Loading

emilazy Nov 11, 2024

emilazy Nov 11, 2024

Bot-wxt1221 Nov 11, 2024 •

edited

Loading

Atemu left a comment

Atemu commented Nov 12, 2024

ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 #354396

ffmpeg-livepeer: init at 7.0.1; livepeer: 0.5.20 -> 0.8.0 #354396

Conversation

Bot-wxt1221 commented Nov 8, 2024 • edited Loading

Things done

This comment was marked as resolved.

stepbrobd commented Nov 8, 2024 • edited Loading

nixpkgs-review result

aarch64-darwin

khaneliman commented Nov 9, 2024

emilazy commented Nov 9, 2024

stepbrobd commented Nov 9, 2024

Bot-wxt1221 commented Nov 9, 2024 • edited Loading

emilazy commented Nov 9, 2024 • edited Loading

Bot-wxt1221 commented Nov 9, 2024

Atemu commented Nov 11, 2024

Bot-wxt1221 commented Nov 11, 2024

Atemu left a comment

Choose a reason for hiding this comment

Bot-wxt1221 commented Nov 11, 2024

Atemu commented Nov 11, 2024

Bot-wxt1221 commented Nov 11, 2024 • edited Loading

Atemu left a comment

Choose a reason for hiding this comment

jopejoe1 Nov 11, 2024

Choose a reason for hiding this comment

reckenrode Nov 11, 2024

Choose a reason for hiding this comment

reckenrode Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Atemu Nov 11, 2024

Choose a reason for hiding this comment

Bot-wxt1221 Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

jopejoe1 Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

emilazy Nov 11, 2024

Choose a reason for hiding this comment

emilazy Nov 11, 2024

Choose a reason for hiding this comment

Bot-wxt1221 Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Atemu left a comment

Choose a reason for hiding this comment

Atemu commented Nov 12, 2024

Bot-wxt1221 commented Nov 8, 2024 •

edited

Loading

stepbrobd commented Nov 8, 2024 •

edited

Loading

`nixpkgs-review` result

`aarch64-darwin`

Bot-wxt1221 commented Nov 9, 2024 •

edited

Loading

emilazy commented Nov 9, 2024 •

edited

Loading

Bot-wxt1221 commented Nov 11, 2024 •

edited

Loading

reckenrode Nov 11, 2024 •

edited

Loading

Bot-wxt1221 Nov 11, 2024 •

edited

Loading

jopejoe1 Nov 11, 2024 •

edited

Loading

Bot-wxt1221 Nov 11, 2024 •

edited

Loading