Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/netbox: clear old static files on upgrade #354036

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

minijackson
Copy link
Member

This fixes an issue where upgrading NetBox didn't correctly clean old
files, and the interface wasn't correct / didn't show object relations.

Also switch to using a symlink to check if we want to run the upgrade script.

This makes it so that the upgrade script also runs when the
configuration changed, or when plugins were added.

This is also a hack to force everyone to run the upgrade script again,
since static files might have been copied incorrectly.

See discussions in #331750 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes an issue where upgrading NetBox didn't correctly clean old
files, and the interface wasn't correct / didn't show object relations.
This makes it so that the upgrade script also runs when the
configuration changed, or when plugins were added.

This is also a hack to force everyone to run the upgrade script again,
since static files might have been copied incorrectly (see parent commit)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 6, 2024
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but LGTM

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 6, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2024
@minijackson minijackson added the backport release-24.11 Backport PR automatically label Nov 22, 2024
@minijackson minijackson merged commit a25e476 into NixOS:master Nov 22, 2024
29 checks passed
@minijackson minijackson deleted the netbox-fix-collectstatic branch November 22, 2024 09:19
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants