ffmpeg: disable xev{e,d} when under 7.1 #353198
Conversation
The update to xev caused an incompatibility with ffmpeg 7.0 which broke handbrake's ffmpeg. Fixes NixOS#353072
|
Does Handbrake actually want |
Handbrake does compile and run without |
|
We’ve been discouraging people from using it: #271863. I think some subset of CUDA stuff is the main thing some people want that isn’t in our main FFmpeg. I would be surprised if Handbrake relies on |
|
I can quickly make a pr to move handbrake to without |
|
It was added in #52453 (comment), “more codecs/containers for input and more processing possibilities, which seems sane for the rich video transcoder” – which I think would generally go against our modern advice. @Atemu Does NVIDIA / AMD hardware‐accelerated encoding work with the stock FFmpeg? I think that’s the main thing we shouldn’t break, since I expect a lot of people will want fast encoding when using Handbrake. CUDA filters or whatever seem like something we can do without here. |
|
VAAPI encode works but IDK about Nvidia. Jellyfin requires more features such as OpenCL for full hardware transcoding though. I've been meaning to figure that out and make our default ffmpeg have those features by default so that everyone can just use that. |
|
|
Let's unbreak master for now, we can discuss removing the dependency on ffmpeg-full in #271863. |
ffmpeg_7-full is required by jellyfin-ffmpeg and is currently broken. ref: NixOS/nixpkgs#353198 Signed-off-by: Chinmay D. Pai <[email protected]>
The update to xev caused an incompatibility with ffmpeg 7.0 which broke handbrake's ffmpeg.
Fixes #353072
Closes #353168
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.