Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gortr: Adopting package and refactor #351612

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Oct 27, 2024

gortr has been lacking a maintainer. I am volunteering to adopt the package maintainership as I am relying on it myself.

Furthermore, I have:

  • Reformatted it with nixfmt
  • Migrated it to the by-name directory
  • Remove with lib usage
  • Replaced sha256 attribute by hash

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@stv0g stv0g changed the title Adopting gortr gortr: Adopting package and refactor Oct 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 27, 2024
@stv0g stv0g requested a review from 0x4A6F November 5, 2024 07:47
@0x4A6F 0x4A6F merged commit e6ec6af into NixOS:master Nov 5, 2024
39 checks passed
@0x4A6F
Copy link
Member

0x4A6F commented Nov 5, 2024

You are aware, that that upstream is deprecated? See #293424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants