Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xen: make the EFI build mandatory, fix XSA 462 description #347810

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

SigmaSquadron
Copy link
Contributor

@SigmaSquadron SigmaSquadron commented Oct 10, 2024

As binutils-efi no longer exists, there's no longer any reason to have the withEFI flag. All supported builds should also build xen.efi.

Things done

  • No rebuilds: we're already building with EFI enabled and the description is only appended to a meta attribute.
  • No release notes: change is minor.
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

As binutils-efi no longer exists, there's no longer any reason to have
the withEFI flag. All supported builds should also build xen.efi.

Signed-off-by: Fernando Rodrigues <[email protected]>
@github-actions github-actions bot added the 6.topic: xen-project The Xen Project hypervisor label Oct 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 11, 2024
ci/OWNERS Outdated Show resolved Hide resolved
The newlines break the markdown quote in the longDescription.

Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron SigmaSquadron changed the title xen: make the EFI build mandatory, add OWNERS entry for the team xen: make the EFI build mandatory, fix XSA 462 description Oct 11, 2024
Copy link
Member

@CertainLach CertainLach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, it might be useful for client-only library usage...

Not much sense after multi-output derivation split, though.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 15, 2024
@emilazy emilazy merged commit 88a7f67 into NixOS:master Oct 17, 2024
38 checks passed
@SigmaSquadron SigmaSquadron deleted the xen-efi branch December 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: xen-project The Xen Project hypervisor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants