curl: fixes for static linking on Darwin #346950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
ofborg
bot
added
6.topic: darwin
reckenrode
force-pushed
the
push-wlvkzvlomsnn
branch
from
bd06fed to
92e2cfc
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-wlvkzvlomsnn
branch
2 times, most recently
from
97d73fb to
983d65d
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
Some of curl’s dependencies require libiconv, but the `configure` script is not including `-liconv` in the linker flags when checking for those dependencies in static builds. That causes the check to fail and prevents curl from building statically on Darwin.
reckenrode
force-pushed
the
push-wlvkzvlomsnn
branch
from
983d65d to
fbf56c1
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
emilazy
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
emilazy
approved these changes
Oct 11, 2024
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Oct 12, 2024
This works since <NixOS#346950>.
13 tasks
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Oct 17, 2024
This works since <NixOS#346950>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could probably target staging directly, but enabling x86_64-darwin support depends on #346043 to fix cross-compilation for x86_64-darwin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.