Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tclPackages: init #344716

Merged
merged 4 commits into from
Oct 26, 2024
Merged

tclPackages: init #344716

merged 4 commits into from
Oct 26, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 26, 2024

Motivation: https://discourse.nixos.org/t/a-tcl-package-set/28071

A successor of #235614 with two key differences:

  • I added a by-name hierarchy.
  • I removed versioned sets. We can instead rely on the stubs mechanism (between minor versions at least). Versioned sets can be added later if we we find they are needed.

The treewide migration of existing packages is its own commit to make review easier.

To do:

  • Finish moving packages to tcl-modules
  • Documentation
  • Enable stubs on applicable packages. Let's do this later so we avoid rebuilds in this PR.

Pinging people who expressed interest in this: @infinisil @nat-418 @andreabedini
Pinging the tcl maintainer: @agbrooks


Note

ofborg will report some rebuilds because of the change in attrpaths, however the store hashes are the same. This pr should cause 0 actual rebuilds

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/a-tcl-package-set/28071/10

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@fgaz fgaz force-pushed the tcl-set branch 3 times, most recently from 84f2a05 to 8894cbc Compare October 3, 2024 11:33
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Oct 3, 2024
@ofborg ofborg bot requested review from nat-418 and MatthewCroughan October 3, 2024 14:04
@fgaz fgaz force-pushed the tcl-set branch 2 times, most recently from 5d5b19b to 680cf58 Compare October 4, 2024 06:20
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 4, 2024
@fgaz fgaz force-pushed the tcl-set branch 2 times, most recently from 3a39c52 to f3a6074 Compare October 4, 2024 08:11
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 4, 2024
@ofborg ofborg bot requested a review from thoughtpolice October 4, 2024 10:13
@fgaz
Copy link
Member Author

fgaz commented Oct 22, 2024

@agbrooks thanks!

Tcl packages are being updated because of the recent 9.0 release, so conflicts are likely. Most other review requests are due to all the renames, so I will add a a changelog entry and merge this pr on Friday unless there are objections.

@fgaz fgaz added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 25, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog labels Oct 25, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 25, 2024
@ofborg ofborg bot requested a review from agbrooks October 25, 2024 23:08
@fgaz fgaz merged commit 00d5b58 into NixOS:master Oct 26, 2024
26 checks passed
@fgaz fgaz deleted the tcl-set branch October 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: tcl 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants