-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tclPackages: init #344716
Merged
Merged
tclPackages: init #344716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
fgaz
commented
Oct 2, 2024
fgaz
force-pushed
the
tcl-set
branch
3 times, most recently
from
October 3, 2024 11:33
84f2a05
to
8894cbc
Compare
fgaz
force-pushed
the
tcl-set
branch
2 times, most recently
from
October 4, 2024 06:20
5d5b19b
to
680cf58
Compare
ofborg
bot
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Oct 4, 2024
fgaz
force-pushed
the
tcl-set
branch
2 times, most recently
from
October 4, 2024 08:11
3a39c52
to
f3a6074
Compare
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Oct 4, 2024
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
October 11, 2024 16:14
agbrooks
approved these changes
Oct 22, 2024
@agbrooks thanks! Tcl packages are being updated because of the recent 9.0 release, so conflicts are likely. Most other review requests are due to all the renames, so I will add a a changelog entry and merge this pr on Friday unless there are objections. |
fgaz
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Oct 25, 2024
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
labels
Oct 25, 2024
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: policy discussion
6.topic: python
6.topic: tcl
8.has: changelog
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: https://discourse.nixos.org/t/a-tcl-package-set/28071
A successor of #235614 with two key differences:
The treewide migration of existing packages is its own commit to make review easier.
To do:
Enable stubs on applicable packages.Let's do this later so we avoid rebuilds in this PR.Pinging people who expressed interest in this: @infinisil @nat-418 @andreabedini
Pinging the tcl maintainer: @agbrooks
Note
ofborg will report some rebuilds because of the change in attrpaths, however the store hashes are the same. This pr should cause 0 actual rebuilds