Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/by-name: Update manual migration guidelines #340235

Merged

Conversation

infinisil
Copy link
Member

Description of changes

Since this original guideline has been written, the new nixpkgs-merge-bot has appeared, and depends on packages being in pkgs/by-name. It's totally fine to move packages for that purpose only.

Also update the guidelines to indicate that it might take some time still for the automated migration to be completed.

Ping @mweinelt @eclairevoyant @Atemu @felixsinger from #338675


Add a 👍 reaction to pull requests you find important.

Since this original guideline has been written, the new
nixpkgs-merge-bot has appeared, and depends on packages being in
`pkgs/by-name`. It's totally fine to move packages for that purpose
only.

Also update the guidelines to indicate that it might take some time
still for the automated migration to be completed.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2024
@Aleksanaa Aleksanaa added the 8.has: documentation This PR adds or changes documentation label Sep 7, 2024
Copy link
Member

@felixsinger felixsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Sep 7, 2024
@0x4A6F 0x4A6F merged commit 7a04ee4 into NixOS:master Sep 7, 2024
25 checks passed
@infinisil infinisil deleted the by-name-manual-migration-guidelines-update branch September 12, 2024 12:43
AndersonTorres added a commit to museoa/nixpkgs that referenced this pull request Sep 16, 2024
Manual migration for the sake of by-name migration is no longer discouraged
since NixOS#340235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants