Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

czkawka-full: "init" #339359

Merged
merged 2 commits into from
Sep 13, 2024
Merged

czkawka-full: "init" #339359

merged 2 commits into from
Sep 13, 2024

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 3, 2024

Description of changes

Closes #339308

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- use explicit self-reference
  - so that we don't need to refer to czkawka in the input set
- nixfmt-rfc-style
@AndersonTorres AndersonTorres marked this pull request as ready for review September 3, 2024 22:51
@AndersonTorres AndersonTorres marked this pull request as draft September 3, 2024 23:46
This meta-package is a convenient wrapper for czkawka, useful to include extra
auxiliary packages - like ffmpeg.

Many thanks for `parallel` package keepers! The idea is nice!
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 4, 2024
@ofborg ofborg bot requested review from 0x4A6F and yanganto September 4, 2024 01:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 4, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review September 4, 2024 14:45
@AndersonTorres
Copy link
Member Author

@edermats32 can you please test it?

@0x4A6F
Copy link
Member

0x4A6F commented Sep 7, 2024

Result of nixpkgs-review pr 339359 run on x86_64-linux 1

2 packages built:
  • czkawka
  • czkawka-full

@edermats32
Copy link

@edermats32 can you please test it?

Sorry for taking so long to respond, didn't see you tagged me until now.
Anyway, I'm pretty new to Nix and Git in general.
How exactly do I test it?

Do i clone the nixpkgs repo and then run:

git fetch origin pull/339359/head:pr-339359
git checkout pr-339359
nix-build -A czkawka-full
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 339359"

and then test run the binary?

I did some research but didn't find a straight forward answer.
It might be me not being familiar enough with nix or just being blind though.

@0x4A6F
Copy link
Member

0x4A6F commented Sep 11, 2024

# in checkout of nixpkgs repo:
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 339359"
./results/czkawka-full/bin/czkawka_gui

@edermats32
Copy link

edermats32 commented Sep 13, 2024

# in checkout of nixpkgs repo:
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 339359"
./results/czkawka-full/bin/czkawka_gui

@AndersonTorres
I complied it and ran it as instructed above.
I can confirm that finding similar videos now works even if the system previously did not have ffmpeg installed.
The system i tested on:

nix-shell -p nix-info --run "nix-info -m"

 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.46, NixOS, 24.05 (Uakari), 24.05.4169.797f7dc49e0b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"nixos-24.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@0x4A6F 0x4A6F merged commit 252c937 into NixOS:master Sep 13, 2024
29 of 30 checks passed
@AndersonTorres AndersonTorres deleted the upload-czkawka branch December 14, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

czkawka - missing ffmpeg dependency (used for comparing videos)
3 participants