Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iotools: Move package definition into by-name directory #338674

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

felixsinger
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 31, 2024
@eclairevoyant
Copy link
Contributor

same feedback as on #338675

@felixsinger
Copy link
Member Author

same feedback as on #338675

Same feedback as in #338675.

@eclairevoyant
Copy link
Contributor

As there's no substantial change that wouldn't already be covered by a treewide, and this essentially goes against guidelines that try to prevent PR churn/spam, I'd vote to close this PR.

@felixsinger felixsinger closed this Sep 6, 2024
@felixsinger felixsinger deleted the pkgs/iotools/move branch September 6, 2024 22:11
@felixsinger felixsinger restored the pkgs/iotools/move branch September 6, 2024 22:33
@felixsinger felixsinger reopened this Sep 6, 2024
Signed-off-by: Felix Singer <[email protected]>
@0x4A6F 0x4A6F merged commit 194cc3d into NixOS:master Sep 7, 2024
23 of 25 checks passed
@felixsinger felixsinger deleted the pkgs/iotools/move branch September 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants