Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-langservers-extracted: fix build #335559

Merged

Conversation

isabelroses
Copy link
Member

Description of changes

The changes made in this PR to vscode lead to vscode-langservers-extracted breaking

closes #335533

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@obreitwi
Copy link
Contributor

Result of nixpkgs-review pr 335559 run on x86_64-linux 1

1 package built:
  • vscode-langservers-extracted

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 18, 2024
@fpletz fpletz merged commit dbde864 into NixOS:master Aug 18, 2024
29 of 31 checks passed
@isabelroses isabelroses deleted the pkgs/vscode-langservers-extracted/fix branch August 18, 2024 21:30
khaneliman added a commit to nix-community/nixvim that referenced this pull request Aug 19, 2024
… package)

Re-enable after NixOS/nixpkgs#335559 is
available in nixos-unstable.
khaneliman added a commit to nix-community/nixvim that referenced this pull request Aug 19, 2024
… package)

Re-enable after NixOS/nixpkgs#335559 is
available in nixos-unstable.
khaneliman added a commit to nix-community/nixvim that referenced this pull request Aug 20, 2024
… package)

Re-enable after NixOS/nixpkgs#335559 is
available in nixos-unstable.
khaneliman added a commit to nix-community/nixvim that referenced this pull request Aug 20, 2024
… package)

Re-enable after NixOS/nixpkgs#335559 is
available in nixos-unstable.
MattSturgeon added a commit to MattSturgeon/nix-config that referenced this pull request Aug 21, 2024
I don't use it and it's currently broken until
NixOS/nixpkgs#335559 is available in nixos-unstable.
Scrumplex added a commit to Scrumplex/flake that referenced this pull request Aug 21, 2024
jwyuen added a commit to jwyuen/jwy-gh0stzk-dotfiles that referenced this pull request Aug 22, 2024
Due to an issue on unstable, had to disable 3 lsp servers in neovim
config.  (see NixOS/nixpkgs#335559)

Made various small changes to keep up w/ nix api changes
@nevivurn nevivurn added the backport release-24.05 Backport PR automatically label Oct 12, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: vscode-langservers-extracted
5 participants