-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-langservers-extracted: fix build #335559
Merged
fpletz
merged 1 commit into
NixOS:master
from
isabelroses:pkgs/vscode-langservers-extracted/fix
Aug 18, 2024
Merged
vscode-langservers-extracted: fix build #335559
fpletz
merged 1 commit into
NixOS:master
from
isabelroses:pkgs/vscode-langservers-extracted/fix
Aug 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of 1 package built:
|
obreitwi
approved these changes
Aug 18, 2024
isabelroses
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Aug 18, 2024
fpletz
approved these changes
Aug 18, 2024
khaneliman
added a commit
to nix-community/nixvim
that referenced
this pull request
Aug 19, 2024
… package) Re-enable after NixOS/nixpkgs#335559 is available in nixos-unstable.
khaneliman
added a commit
to nix-community/nixvim
that referenced
this pull request
Aug 19, 2024
… package) Re-enable after NixOS/nixpkgs#335559 is available in nixos-unstable.
khaneliman
added a commit
to nix-community/nixvim
that referenced
this pull request
Aug 20, 2024
… package) Re-enable after NixOS/nixpkgs#335559 is available in nixos-unstable.
khaneliman
added a commit
to nix-community/nixvim
that referenced
this pull request
Aug 20, 2024
… package) Re-enable after NixOS/nixpkgs#335559 is available in nixos-unstable.
MattSturgeon
added a commit
to MattSturgeon/nix-config
that referenced
this pull request
Aug 21, 2024
I don't use it and it's currently broken until NixOS/nixpkgs#335559 is available in nixos-unstable.
Scrumplex
added a commit
to Scrumplex/flake
that referenced
this pull request
Aug 21, 2024
Needs: NixOS/nixpkgs#335559 Signed-off-by: Sefa Eyeoglu <[email protected]>
jwyuen
added a commit
to jwyuen/jwy-gh0stzk-dotfiles
that referenced
this pull request
Aug 22, 2024
Due to an issue on unstable, had to disable 3 lsp servers in neovim config. (see NixOS/nixpkgs#335559) Made various small changes to keep up w/ nix api changes
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 1
This PR was reviewed and approved by one reputable person
backport release-24.05
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The changes made in this PR to vscode lead to vscode-langservers-extracted breaking
closes #335533
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.