bash-language-server: fix broken package

[ck3d]

Description of changes

Fix the build phase of the package and add minor changes like, version test, remove unused variable and make shellcheck as default.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[amarshall]

Can confirm package was broken, and that this remedies it. Changes overall look good, but not familiar with this drv specifically.

[doronbehar]

I don't understand what this PR is for (besides the --suffix change), bash-language-server builds fine for me on branch master.

[doronbehar]

An explanation in the commit message for this change would be nice. pnpmWorkspace is an attribute added to support here:

#323493

[ck3d]

I remove the commit. I think this should be discussed in your mentioned PR.

[ck3d]

Without this this PR, the package is built, but the executable fails to start. I incorporated your recommendations.

[doronbehar]

Without this this PR, the package is built, but the executable fails to start. I incorporated your recommendations.

OK I see now what you are talking about. How did you manage to find out the pnpm compile server command? I wonder if the documentation for pnpm could be improved...

[doronbehar]

I will merge when CI is green..

[ck3d]

pnpm compile is a shorthand for pnpm run compile, see https://pnpm.io/8.x/cli/run
Script compile is the documented target, see https://github.com/bash-lsp/bash-language-server/blob/main/docs/development-guide.md#initial-setup

I additionally passed server as argument to compile to only compile server and not vscode-client. The resulting command is tsc -b server.
See also https://github.com/bash-lsp/bash-language-server/blob/main/package.json#L6

[doronbehar]

pnpm compile is a shorthand for pnpm run compile, see pnpm.io/8.x/cli/run Script compile is the documented target, see bash-lsp/bash-language-server@main/docs/development-guide.md#initial-setup

I additionally passed server as argument to compile to only compile server and not vscode-client. The resulting command is tsc -b server. See also bash-lsp/bash-language-server@main/package.json#L6

Thanks for explaining. I added a note to the main comment of #317927 .