llvmPackages: fix wasm with common opts

[RossComputerGuy]

Description of changes

CC @spiage

Fixes things using WASM like Firefox.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[RossComputerGuy]

@ofborg build firefox

[spiage]

@SuperSandro2000 @vcunat Hi! Can this two checks for firefox on darwin be skipped? This fix should fix issue with #330316
Both firefox and thunderbird builds fine with current commit on my machine and by ofborg too

[vcunat]

No need to wait for this one, if you're confident that it's irrelevant. I think ofBorg can often get overloaded for darwin, so it takes time.

[spiage]

No need to wait for this one, if you're confident that it's irrelevant. I think ofBorg can often get overloaded for darwin, so it takes time.

Thank you!

@RossComputerGuy can you break it?

[vcunat]

Actually, firefox isn't even supported in nixpkgs for *-darwin.

[spiage]

@vcunat could you please help me? How can I stop these two tests? Or can only @RossComputerGuy do this?

[RossComputerGuy]

Sorry I just woke up, Firefox on Linux built at least which is all we need to prove the fix. The error which occurred happened during configuration and not at building, I just didn't have enough time to properly test this before I had to go to sleep.

[gador]

PR LGTM. I got the config error on current master and the build for firefox is already way past it. I'm building firefox (and run nixpkgs-review on the buildserver) right now for x86_64-linux and can merge after they succeed. Or someone else merges before it ;-)

[spiage]

Thank you! Every is fine now:
Version 15379 -> 15380:
firefox-unwrapped: -73.1 KiB
nixos-system-a7: 24.11.20240804.f099c76 → 24.11.20240804.e16b22c