Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualboxGuestAdditions: cleanup #327344

Merged
merged 1 commit into from
Jul 15, 2024
Merged

virtualboxGuestAdditions: cleanup #327344

merged 1 commit into from
Jul 15, 2024

Conversation

FriedrichAltheide
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FriedrichAltheide FriedrichAltheide requested review from dasJ and blitz July 15, 2024 12:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 15, 2024
@thillux thillux self-requested a review July 15, 2024 13:56
thillux
thillux approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@thillux thillux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x4A6F 0x4A6F merged commit 0c4ade4 into NixOS:master Jul 15, 2024
23 checks passed
@FriedrichAltheide FriedrichAltheide added the backport release-24.05 Backport PR automatically label Jul 15, 2024
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@thillux thillux thillux approved these changes

@dasJ dasJ Awaiting requested review from dasJ

@blitz blitz Awaiting requested review from blitz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FriedrichAltheide @thillux @wegank @0x4A6F