Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.scalene: fix build on Linux and Darwin #326169

Merged
merged 1 commit into from
Jul 11, 2024
Merged

python312Packages.scalene: fix build on Linux and Darwin #326169

merged 1 commit into from
Jul 11, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 10, 2024 •
edited
Loading

Fixes failing runtime dependencies check on Darwin via pythonRemoveDeps. Tested on Linux x86 and both flavors of Darwin to ensure no regressions.

Fixes #326167

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 10, 2024
@sarahec sarahec force-pushed the scalene-no-nvidia-ml-py3 branch from 24a65f5 to faf50ff Compare July 11, 2024 04:11
@eclairevoyant
Copy link
Contributor

Other than the above comment, tested locally and it lgtm

@superherointj
Copy link
Contributor

@sarahec Please run nixfmt (rfc).
And clean-up the post to reflect situation. I don't see any cherry-picks. (Better to not add stale information.)

@superherointj superherointj added the awaiting_changes (old Marvin label, do not use) label Jul 11, 2024
@sarahec sarahec force-pushed the scalene-no-nvidia-ml-py3 branch from faf50ff to f08d1e0 Compare July 11, 2024 16:42
@superherointj superherointj removed the awaiting_changes (old Marvin label, do not use) label Jul 11, 2024
@sarahec
Copy link
Contributor Author

sarahec commented Jul 11, 2024

@sarahec Please run nixfmt (rfc).

Done. I've now switched my formatter to nixfmt

And clean-up the post to reflect situation. I don't see any cherry-picks. (Better to not add stale information.)

Done.

Thank you for your help!

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 326169 run on x86_64-linux 1

4 packages built:
  • python311Packages.scalene
  • python311Packages.scalene.dist
  • scalene (python312Packages.scalene)
  • scalene.dist (python312Packages.scalene.dist)

@sarahec
Copy link
Contributor Author

sarahec commented Jul 11, 2024

Result of nixpkgs-review pr 326169 run on aarch64-darwin 1

4 packages built:
  • python311Packages.scalene
  • python311Packages.scalene.dist
  • scalene (python312Packages.scalene)
  • scalene.dist (python312Packages.scalene.dist)

@sarahec sarahec changed the title python312Packages.scalene: fix build python312Packages.scalene: fix build on Darwin Jul 11, 2024
@sarahec sarahec added the 6.topic: darwin Running or building packages on Darwin label Jul 11, 2024
@superherointj superherointj merged commit 9a517fb into NixOS:master Jul 11, 2024
29 of 31 checks passed
@sarahec sarahec changed the title python312Packages.scalene: fix build on Darwin python312Packages.scalene: fix build on Linux and Darwin Jul 11, 2024
@sarahec sarahec deleted the scalene-no-nvidia-ml-py3 branch July 11, 2024 17:43
@eclairevoyant eclairevoyant mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

@eclairevoyant eclairevoyant eclairevoyant approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: python312Libraries.scalene
3 participants
@sarahec @eclairevoyant @superherointj