Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs_18: 18.20.3 -> 18.20.4 #325620

Merged
merged 1 commit into from
Jul 11, 2024
Merged

nodejs_18: 18.20.3 -> 18.20.4 #325620

merged 1 commit into from
Jul 11, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 8, 2024

Description of changes

Security release: https://github.com/nodejs/node/releases/tag/v18.20.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jul 8, 2024
@ofborg ofborg bot requested a review from cillianderoiste July 8, 2024 21:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 8, 2024
GrumpyMeow
GrumpyMeow approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@GrumpyMeow GrumpyMeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@emilazy emilazy mentioned this pull request Jul 9, 2024
Merged
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 10, 2024
@0x4A6F 0x4A6F merged commit d586835 into NixOS:staging Jul 11, 2024
31 checks passed
@aduh95 aduh95 deleted the patch-2 branch July 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrumpyMeow GrumpyMeow GrumpyMeow approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @GrumpyMeow @0x4A6F @wegank