Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam: 2.1.5 -> 2.2.0 #324381

Merged
merged 1 commit into from
Jul 16, 2024
Merged

opam: 2.1.5 -> 2.2.0 #324381

merged 1 commit into from
Jul 16, 2024

Conversation

kit-ty-kate
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 3, 2024
@jackyliu16
Copy link
Contributor

Result of nixpkgs-review pr 324381 run on x86_64-linux 1

10 packages failed to build:
  • dune-release
  • ocamlPackages.opam-core
  • ocamlPackages.opam-format
  • ocamlPackages.opam-repository
  • ocamlPackages.opam-state
  • opam
  • opam-installer
  • opam-publish
  • opam.installer
  • opam2json

@kit-ty-kate kit-ty-kate force-pushed the opam-2.2.0 branch 2 times, most recently from dff61c6 to aeb4b41 Compare July 4, 2024 12:53
@OlivierNicole
Copy link
Contributor

Replacing opam-shebangs.patch with this https://gist.github.com/OlivierNicole/84b7b764a6a3d32599d5fbeb5ac59d9f seems to patch properly

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4213

OlivierNicole
OlivierNicole approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@OlivierNicole OlivierNicole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new package definition seems sensible and it bulids and works as expected for me.

@SuperSandro2000 SuperSandro2000 merged commit d899912 into NixOS:master Jul 16, 2024
24 of 26 checks passed
@vbgl
Copy link
Contributor

vbgl commented Jul 29, 2024

See #329608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierNicole OlivierNicole OlivierNicole approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kit-ty-kate @jackyliu16 @OlivierNicole @nixos-discourse @vbgl @SuperSandro2000 @NixOSInfra