Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

czkawka: fix x86 darwin #323687

Merged
merged 1 commit into from
Jul 1, 2024
Merged

czkawka: fix x86 darwin #323687

merged 1 commit into from
Jul 1, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jul 1, 2024 •
edited
Loading

Description of changes

https://hydra.nixos.org/build/262699687/nixlog/2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 1, 2024
@ofborg ofborg bot requested review from AndersonTorres, yanganto and 0x4A6F July 1, 2024 01:39
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 1, 2024
@khaneliman
Copy link
Contributor Author

Result of nixpkgs-review pr 323687 run on x86_64-darwin 1

1 package built:
  • czkawka

0x4A6F
0x4A6F approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh noes, this will break nice rendering on zh.fail.

Thanks ❤️

@0x4A6F 0x4A6F merged commit b703c14 into NixOS:master Jul 1, 2024
29 checks passed
@khaneliman khaneliman deleted the czkawka branch July 2, 2024 02:13
@0x4A6F 0x4A6F mentioned this pull request Jul 2, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@yanganto yanganto Awaiting requested review from yanganto

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaneliman @0x4A6F