-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresqlPackages.pgvecto-rs: 0.2.1 -> 0.3.0 #321617
Conversation
This looks good, feel free to ping me again when 1.79 lands on master |
Now that 1.79 is in, this should be good to go. |
@happysalada I was waiting for it to be available in master, but I can rebase it on staging if you prefer |
You are completely right here, lets wait for it to land on master its just easier. |
Rust 1.79 seems to already be in master, but perhaps we should only merge this after Immich supports 0.3.0? Especially relevant since #324127 requires this package. EDIT: Keeping it as draft for now due to this. |
I've rebased this on master and it builds now. I had to do a small change to |
5d2d006
to
491b259
Compare
491b259
to
da5ae1b
Compare
The PR looks good but youre right we should probably wait for immich support before merging. |
Immich will support pgvecto-rs 0.3.0 in the next release: immich-app/immich#11624 |
https://github.com/immich-app/immich/releases/tag/v1.112.0 |
Should we wait until the updated of immich gets merged ? |
That seems reasonable to me. |
Description of changes
https://github.com/tensorchord/pgvecto.rs/releases/tag/v0.3.0
However, this needs rustc 1.79, so it's failing to build.Waiting for #320250Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.