Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlPackages.pgvecto-rs: 0.2.1 -> 0.3.0 #321617

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Jun 21, 2024

Description of changes

https://github.com/tensorchord/pgvecto.rs/releases/tag/v0.3.0

However, this needs rustc 1.79, so it's failing to build.
Waiting for #320250

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@happysalada
Copy link
Contributor

This looks good, feel free to ping me again when 1.79 lands on master

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@happysalada
Copy link
Contributor

Now that 1.79 is in, this should be good to go.
Do you have time to do a quick nixpkgs-review or local test by any chance ?

@diogotcorreia
Copy link
Member Author

@happysalada I was waiting for it to be available in master, but I can rebase it on staging if you prefer

@happysalada
Copy link
Contributor

You are completely right here, lets wait for it to land on master its just easier.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Jul 29, 2024

Rust 1.79 seems to already be in master, but perhaps we should only merge this after Immich supports 0.3.0?
See immich-app/immich#11091

Especially relevant since #324127 requires this package.

EDIT: Keeping it as draft for now due to this.

@diogotcorreia
Copy link
Member Author

I've rebased this on master and it builds now. I had to do a small change to buildPgrxExtension since upstream removed the pg_test feature from their crate.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 30, 2024
@happysalada
Copy link
Contributor

happysalada commented Jul 30, 2024

The PR looks good but youre right we should probably wait for immich support before merging.

@diogotcorreia
Copy link
Member Author

Immich will support pgvecto-rs 0.3.0 in the next release: immich-app/immich#11624

@diogotcorreia
Copy link
Member Author

https://github.com/immich-app/immich/releases/tag/v1.112.0
Immich 1.112.0 released with support for this. Marking as ready

@diogotcorreia diogotcorreia marked this pull request as ready for review August 14, 2024 16:43
@happysalada
Copy link
Contributor

Should we wait until the updated of immich gets merged ?

@esclear
Copy link
Contributor

esclear commented Aug 15, 2024

Should we wait until the updated of immich gets merged ?

That seems reasonable to me.

@happysalada happysalada merged commit 2232cae into NixOS:master Sep 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants