Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcachefs-tools: 1.7.0 -> 1.7.0-unstable-2024-05-09 #313424

Merged
merged 3 commits into from
May 26, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented May 21, 2024

Description of changes

Things done

  • Reviewed changelog koverstreet/bcachefs-tools@v1.7.0...3ac510f
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CC @jezcope @codebam @reedriley for testing

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from davidak and Madouura May 21, 2024 16:28
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 21, 2024
@jezcope
Copy link
Contributor

jezcope commented May 22, 2024

@JohnRTitor Seems to work for me:

❯ bcachefs version
1.7.0-unstable-2024-05-09

and everything is mounted correctly. Thanks! 👍🏻

Moved temporarily to unstable to fix NixOS#313350

Also vendor the updated patch for NixOS#309388
from koverstreet/bcachefs-tools#263
@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented May 22, 2024

Added a comment on why moving to unstable is necessary. Should be good to go now

@JohnRTitor JohnRTitor requested review from onny and alyssais May 22, 2024 15:00
@alyssais
Copy link
Member

We can't backport whatever patch fixes the bug? Generally we prefer not to use non-release versions of packages.

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented May 25, 2024

I am not sure which commit specifically fixes that.

Also commits like these fix a bug that throws error messages at boot involving scanning other non-bcachefs filesystems.
Screenshot_20240525-174351_Chrome

I have reviewed the changelog and the changes are pretty harmless bug fixes, also daily driving this as we speak.

24.05 release is around the corner, I don't think we should ship a broken bcachefs-tools with that. That's why I decided to move to to a unstable commit which does not have any substantial changes.

Honestly, I wish that there was a point release to upgrade to. But there is not, so...

@alyssais alyssais merged commit 4f1739c into NixOS:master May 26, 2024
23 of 24 checks passed
@JohnRTitor JohnRTitor deleted the bcachefs-tools branch May 26, 2024 08:44
@JohnRTitor JohnRTitor added the backport release-24.05 Backport PR automatically label May 26, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cannot mount bcachefs from lvm raid0 device
3 participants