Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.netbox-documents: init at 0.7.0; python311Packages.drf-extra-fields: init at 3.7.0 #312866

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented May 19, 2024

Description of changes

Plugin to manage site, circuit and device diagrams and documents in Netbox
https://github.com/jasonyates/netbox-documents

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels May 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 19, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch 6 times, most recently from ff9e251 to 23fc734 Compare May 20, 2024 14:24
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good overall, just some tiny nitpicks

Also, please rename the PR to something like netbox-documents: init at 0.6.3 following contribution guidelines

@Aleksanaa Aleksanaa changed the title Init netbox-documents at 0.6.3 netbox-documents: init at 0.6.3; drf-extra-fields: init at 3.7.0 May 21, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch from f5020ed to 1d4966d Compare May 22, 2024 09:49
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please change the commit message and the PR title to python311Packages.netbox-documents: ... and python311Packages.drf-extra-fields: ..., since these packages are python libraries,

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines-contributing-guidelines

@felbinger felbinger changed the title netbox-documents: init at 0.6.3; drf-extra-fields: init at 3.7.0 python311Packages.netbox-documents: init at 0.6.3; python311Packages.drf-extra-fields: init at 3.7.0 May 22, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch 7 times, most recently from 529f365 to be60595 Compare May 22, 2024 14:50
@felbinger felbinger requested a review from natsukium May 22, 2024 14:51
@felbinger felbinger force-pushed the pkg-netbox-documents branch 2 times, most recently from 891dea0 to db7a42c Compare May 22, 2024 14:58
@felbinger
Copy link
Member Author

felbinger commented Jun 3, 2024

I just noticed the import check doesn't work.

Result of nixpkgs-review pr 312866 run on x86_64-linux
error: builder for '/nix/store/1rk3a1hwkhqj2i59rahhzpsrwibd0b0x-python3.12-netbox-documents-0.6.3.drv' failed with exit code 5;
       last 25 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3
       > checking for references to /build/ in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3...
       > patching script interpreter paths in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3
       > stripping (with command strip and flags -S -p) in  /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3/lib
       > shrinking RPATHs of ELF executables and libraries in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist
       > checking for references to /build/ in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist...
       > patching script interpreter paths in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist
       > Executing pythonRemoveTestsDir
       > Finished executing pythonRemoveTestsDir
       > Running phase: installCheckPhase
       > no Makefile or custom installCheckPhase, doing nothing
       > Running phase: pythonCatchConflictsPhase
       > Running phase: pythonRemoveBinBytecodePhase
       > Running phase: pythonImportsCheckPhase
       > Executing pythonImportsCheckPhase
       > Running phase: pytestCheckPhase
       > Executing pytestCheckPhase
       > ============================= test session starts ==============================
       > platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.4.0
       > rootdir: /build/source
       > collected 0 items                                                              
       >
       > ============================ no tests ran in 0.01s =============================
       > /nix/store/xfhkjnpqjwlf6hlk1ysmq3aaq80f3bjj-stdenv-linux/setup: line 1579: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/1rk3a1hwkhqj2i59rahhzpsrwibd0b0x-python3.12-netbox-documents-0.6.3.drv'.
error: builder for '/nix/store/xpn91k1y0fh8z722gx49mpzvl45xwhlv-python3.11-netbox-documents-0.6.3.drv' failed with exit code 5;
       last 25 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3
       > checking for references to /build/ in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3...
       > patching script interpreter paths in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3
       > stripping (with command strip and flags -S -p) in  /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3/lib
       > shrinking RPATHs of ELF executables and libraries in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist
       > checking for references to /build/ in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist...
       > patching script interpreter paths in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist
       > Executing pythonRemoveTestsDir
       > Finished executing pythonRemoveTestsDir
       > Running phase: installCheckPhase
       > no Makefile or custom installCheckPhase, doing nothing
       > Running phase: pythonCatchConflictsPhase
       > Running phase: pythonRemoveBinBytecodePhase
       > Running phase: pythonImportsCheckPhase
       > Executing pythonImportsCheckPhase
       > Running phase: pytestCheckPhase
       > Executing pytestCheckPhase
       > ============================= test session starts ==============================
       > platform linux -- Python 3.11.9, pytest-8.1.1, pluggy-1.4.0
       > rootdir: /build/source
       > collected 0 items                                                              
       >
       > ============================ no tests ran in 0.00s =============================
       > /nix/store/xfhkjnpqjwlf6hlk1ysmq3aaq80f3bjj-stdenv-linux/setup: line 1579: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/xpn91k1y0fh8z722gx49mpzvl45xwhlv-python3.11-netbox-documents-0.6.3.drv'.
error: 2 dependencies of derivation '/nix/store/s00zjcqgk651ywp7s2nf86hnwr55n236-review-shell.drv' failed to build

can't really see any error in the full logs...

4 packages failed to build:
  • python311Packages.netbox-documents
  • python311Packages.netbox-documents.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
4 packages built:
  • python311Packages.drf-extra-fields
  • python311Packages.drf-extra-fields.dist
  • python312Packages.drf-extra-fields
  • python312Packages.drf-extra-fields.dist

No idea what I did wrong, any advise?

@felbinger felbinger force-pushed the pkg-netbox-documents branch from db7a42c to cc1e719 Compare June 5, 2024 20:00
@felbinger felbinger force-pushed the pkg-netbox-documents branch 2 times, most recently from 1a60e78 to 6ab1fb0 Compare July 21, 2024 17:00
@felbinger felbinger force-pushed the pkg-netbox-documents branch 2 times, most recently from e6a39c0 to 2cb3a10 Compare July 30, 2024 08:27
@minijackson
Copy link
Member

Note that I've opened #331750 recently, so depending on which gets merged first, one of us will have to upgrade netbox-documents to 0.7.0.

@felbinger
Copy link
Member Author

felbinger commented Aug 2, 2024

@SuperSandro2000 So what do you think, can we merge this pr now? This way we could also backport the plugin, with the update version it can only be used in 24.11 due to netbox 4.0 requirement.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch 2 times, most recently from 46b337b to 447602d Compare October 3, 2024 15:46
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch 2 times, most recently from ce5e28b to 1d79f6b Compare October 4, 2024 15:24
@felbinger felbinger requested a review from natsukium October 4, 2024 19:19
@felbinger felbinger force-pushed the pkg-netbox-documents branch from 1d79f6b to de3762d Compare October 6, 2024 14:23
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Oct 6, 2024
@felbinger
Copy link
Member Author

As SuperSandro2000 suggested in #312861 I removed the release notes entry for this package too.

felbinger and others added 2 commits October 7, 2024 13:50
@SuperSandro2000 SuperSandro2000 changed the title python311Packages.netbox-documents: init at 0.6.3; python311Packages.drf-extra-fields: init at 3.7.0 python311Packages.netbox-documents: init at 0.7.0; python311Packages.drf-extra-fields: init at 3.7.0 Oct 7, 2024
@felbinger felbinger force-pushed the pkg-netbox-documents branch from de3762d to 7f233a7 Compare October 7, 2024 15:34
@SuperSandro2000 SuperSandro2000 merged commit 579b471 into NixOS:master Oct 10, 2024
26 checks passed
@felbinger felbinger deleted the pkg-netbox-documents branch October 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants