-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.netbox-documents: init at 0.7.0; python311Packages.drf-extra-fields: init at 3.7.0 #312866
python311Packages.netbox-documents: init at 0.7.0; python311Packages.drf-extra-fields: init at 3.7.0 #312866
Conversation
ff9e251
to
23fc734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good overall, just some tiny nitpicks
Also, please rename the PR to something like netbox-documents: init at 0.6.3
following contribution guidelines
f5020ed
to
1d4966d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Please change the commit message and the PR title to python311Packages.netbox-documents: ...
and python311Packages.drf-extra-fields: ...
, since these packages are python libraries,
529f365
to
be60595
Compare
891dea0
to
db7a42c
Compare
I just noticed the import check doesn't work. Result of nixpkgs-review pr 312866 run on x86_64-linuxerror: builder for '/nix/store/1rk3a1hwkhqj2i59rahhzpsrwibd0b0x-python3.12-netbox-documents-0.6.3.drv' failed with exit code 5; last 25 log lines: > Running phase: fixupPhase > shrinking RPATHs of ELF executables and libraries in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3 > checking for references to /build/ in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3... > patching script interpreter paths in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3 > stripping (with command strip and flags -S -p) in /nix/store/gp36js8pd20cncz0p0qwk9yhvv61f1jz-python3.12-netbox-documents-0.6.3/lib > shrinking RPATHs of ELF executables and libraries in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist > checking for references to /build/ in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist... > patching script interpreter paths in /nix/store/4349ds2r9g2yvz64dr1l5h7rw7gl2gi7-python3.12-netbox-documents-0.6.3-dist > Executing pythonRemoveTestsDir > Finished executing pythonRemoveTestsDir > Running phase: installCheckPhase > no Makefile or custom installCheckPhase, doing nothing > Running phase: pythonCatchConflictsPhase > Running phase: pythonRemoveBinBytecodePhase > Running phase: pythonImportsCheckPhase > Executing pythonImportsCheckPhase > Running phase: pytestCheckPhase > Executing pytestCheckPhase > ============================= test session starts ============================== > platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.4.0 > rootdir: /build/source > collected 0 items > > ============================ no tests ran in 0.01s ============================= > /nix/store/xfhkjnpqjwlf6hlk1ysmq3aaq80f3bjj-stdenv-linux/setup: line 1579: pop_var_context: head of shell_variables not a function context For full logs, run 'nix log /nix/store/1rk3a1hwkhqj2i59rahhzpsrwibd0b0x-python3.12-netbox-documents-0.6.3.drv'. error: builder for '/nix/store/xpn91k1y0fh8z722gx49mpzvl45xwhlv-python3.11-netbox-documents-0.6.3.drv' failed with exit code 5; last 25 log lines: > Running phase: fixupPhase > shrinking RPATHs of ELF executables and libraries in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3 > checking for references to /build/ in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3... > patching script interpreter paths in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3 > stripping (with command strip and flags -S -p) in /nix/store/7wb8zmykn03zsmrbc2abqpviwikksf4c-python3.11-netbox-documents-0.6.3/lib > shrinking RPATHs of ELF executables and libraries in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist > checking for references to /build/ in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist... > patching script interpreter paths in /nix/store/mabmwc2h146mxlr0s974zk9cmsn45d8y-python3.11-netbox-documents-0.6.3-dist > Executing pythonRemoveTestsDir > Finished executing pythonRemoveTestsDir > Running phase: installCheckPhase > no Makefile or custom installCheckPhase, doing nothing > Running phase: pythonCatchConflictsPhase > Running phase: pythonRemoveBinBytecodePhase > Running phase: pythonImportsCheckPhase > Executing pythonImportsCheckPhase > Running phase: pytestCheckPhase > Executing pytestCheckPhase > ============================= test session starts ============================== > platform linux -- Python 3.11.9, pytest-8.1.1, pluggy-1.4.0 > rootdir: /build/source > collected 0 items > > ============================ no tests ran in 0.00s ============================= > /nix/store/xfhkjnpqjwlf6hlk1ysmq3aaq80f3bjj-stdenv-linux/setup: line 1579: pop_var_context: head of shell_variables not a function context For full logs, run 'nix log /nix/store/xpn91k1y0fh8z722gx49mpzvl45xwhlv-python3.11-netbox-documents-0.6.3.drv'. error: 2 dependencies of derivation '/nix/store/s00zjcqgk651ywp7s2nf86hnwr55n236-review-shell.drv' failed to build can't really see any error in the full logs... 4 packages failed to build:
4 packages built:
No idea what I did wrong, any advise? |
db7a42c
to
cc1e719
Compare
1a60e78
to
6ab1fb0
Compare
e6a39c0
to
2cb3a10
Compare
Note that I've opened #331750 recently, so depending on which gets merged first, one of us will have to upgrade netbox-documents to 0.7.0. |
@SuperSandro2000 So what do you think, can we merge this pr now? This way we could also backport the plugin, with the update version it can only be used in 24.11 due to netbox 4.0 requirement. |
46b337b
to
447602d
Compare
ce5e28b
to
1d79f6b
Compare
1d79f6b
to
de3762d
Compare
As SuperSandro2000 suggested in #312861 I removed the release notes entry for this package too. |
Co-authored-by: OTABI Tomoya <[email protected]> Co-authored-by: Sandro <[email protected]>
Co-authored-by: OTABI Tomoya <[email protected]> Co-authored-by: Sandro <[email protected]>
de3762d
to
7f233a7
Compare
Description of changes
Plugin to manage site, circuit and device diagrams and documents in Netbox
https://github.com/jasonyates/netbox-documents
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.