astro-language-server: init at 2.10.0

[pyrox0]

Description of changes

Creates the astro-language-server package, moving it from nodePackages. I also regenerated node-packages.nix to remove it from that package set, but if that's not wanted to be in this PR, I can remove that. This also updates from 2.8.3 to 2.10.0, see the changelog.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pyrox0]

This makes use of PNPM, so it can be improved with #290715 being merged. If that's merged before this, I'll be glad to update this.

[doronbehar]

I think it'll take time for #290715 :).

[doronbehar]

CI isn't green BTW - hash mismatch.

[pyrox0]

CI isn't green BTW - hash mismatch.

Confirmed the error and fixed.

[gepbird]

Also version 2.9.0 is out, consider bumping.

[pyrox0]

Also version 2.9.0 is out, consider bumping.

Updated, but now I'm getting ERR_PNPM_NO_OFFLINE_META errors when trying to build the package(speciflcally, it happens in installPhase), and I'm unable to figure out how to solve it. Build log is here

[doronbehar]

Damn... Another a hash mismatch in ofborg:

error: hash mismatch in fixed-output derivation '/nix/store/z59ba5lgklsrfjc7rvvh0lfxy70lyb3c-astro-language-server-pnpm-deps-2.9.0.drv':
         specified: sha256-S4CGTnXyY1ICU801hAOQpc0MBNPulkJVBctlao5XPfY=
            got:    sha256-Y6CPjZZrIgMpu54511G3EXOuSfJ/nTS8fLYQmhQaT4g=

I wonder what @Scrumplex will think about it.. @pyrox0 could you run please

nix build --rebuild .#astro-language-server.pnpm-deps

And/Or somehow try to find the culprit for the hash difference?

[getchoo]

Suggested change

	pnpm install --frozen-lockfile --no-optional --ignore-script
	pnpm install --frozen-lockfile --no-optional --ignore-script --force

this is the result of the hash mismatch. without --force, pnpm will only install dependencies for the current architecture. we might want to extract from #290715 or vesktop instead

[pyrox0]

Edited this in and fixed the hash. Thanks for catching this!

Also edited in some other changes from #290715, but still doesn't resolve the build issue.

[pyrox0]

I see now the ERR_PNPM_NO_OFFLINE_META error at ofborg's :/. Seems like an instance of upstream's pnpm/pnpm#5315 ... Not sure what to do.

This is only an error if we use pnpm deploy. To work around this issue we can use the "binary" generated by pnpm build from packages/language-server/bin/nodeServer.js.

I see that, but it mentions that workspaces are not supported atm, and this is a workspace. I'll try to at least use the fetchDeps script, but I can't guarantee I can use it until workspaces are properly supported(if possible)

Even though the new pnpm tooling doesn't support building only a single package from a workspace, we can use it to build all packages if we don't mind wasting some resources.

I packaged using the methods I mentioned above in gepbird@2f17100, tried it in neovim and looks like everything works. The build time is not too bad, approximately 2 minutes, but it produces 400M of files.

Thanks for the ideas in that! I kept the original dependencies process and added some filtering, managed to get it down to ~215 mb. Can you test if this still works? I don't see any reason it shouldn't, but a double-check would be great.

[gepbird]

Tested it and works as expected! You're right, we probably shouldn't adopt the new pnpm tooling until it supports workspaces to save on performance, this builds (approximately) 2x faster with half as much filesize.

[doronbehar]

So Do I understand correctly that this --filter argument is what you would miss support for in pnpm.fetchDeps?

[pyrox0]

The filter thing is important, but also setting dedupe-peer-dependants above, which is required for this package to build properly.

[doronbehar]

The filter thing is important, but also setting dedupe-peer-dependants above, which is required for this package to build properly.

Hmm it'd be nice to make pnpm.fetchDeps accept arguments that would allow to add arbitrarily such config options.. cc @Scrumplex

[doronbehar]

For sure pnpm.configHook will gain benefit if you could add arbitrary flags to it... What do you think about that @Scrumplex ?

[pyrox0]

R.E bin/astro-ls not being executable:

That isn't the case here, both the symlink and the file it points to are both marked executable. I'm still not sure why patchShebangs doesn't work.

[doronbehar]

OK This looks good in principal, but I tend to think it will be beneficial to add the missing options to the pnpm.fetchDeps function and to the pnpm.configHook. Do you think you can work on that @pyrox0 ? This would make this packaging much more elegant and it may be beneficial for future usages of these attributes, especially for packages that use workspaces.

[pyrox0]

I can try to do that at least for the filter attribute, but the extra config options may be a bit more difficult. I'll see what I can do, and will submit it as a separate pull request.

[SuperSandro2000]

Please rebase

[doronbehar]

#323493 (which also needs a reabase :)) is a better alternative. I'll close this one in favor of it.