-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collabora #308151
Collabora #308151
Conversation
This reverts commit be094f3.
I think I just need to build a Also, I don't fully understand what I was doing, so part of it was just getting it to ocmpile. |
Maybe @Minion3665 might be interested. |
Thanks for the ping @drupol, I certainly am! I've worked on getting Collabora packaged outside buildFHSEnv, but not quite got to the state where it worked enough for me to upstream it. @EricTheMagician please let me know if I can help in any way, I am employed by Collabora as a developer so have some experience in compiling it, knowledge of the architecture, etc. |
Oh awesome! Thanks @Minion3665 Where I was having issue is with the runtime (because I didn't want to just package it without the nixos module). @Minion3665 The actual issue I came across is that collabora expects to run an each tab/window process in a chroot environment and I couldn't get past that. It's been a while since I've really sunk my teeth in it, but I'll see what I can find. It's probably that I am still learning to do things the nix way and I'll ask more questions in the next few weeks. |
This was a problem I ran up against as well. Unfortunately, I think we shouldn't try to disable this, Collabora Online expects this for security reasons. The approach I was trying before was to make a NixOS module with some security wrappers to give COOL the capabilities it wants. I think I got into some trouble with trying to force COOL to use a wrapped coolmount binary around this point and never got it working, but it was definitely the most promising approach I have seen...
...and yes, so I think if you did package it without the module you would end up finding it still very challenging to make it run. The module is definitely a good approach. |
Could you elaborate on why? If it's packaged natively, you shouldn't require any such hacks.
Could it perhaps be possible to run each as a systemd service instance? Similar to how systemd-coredumpd creates i.e. |
See #330708 |
Description of changes
Started adding collabora online.
Built-it, but couldn't get the runtime configuration working.
Currently, lots of things wrong with this PR.
This is a work in progress to resolve #218878 (comment)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.