Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.busylight-for-humans: init at 0.32.0 #307469

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Conni2461
Copy link
Member

@Conni2461 Conni2461 commented Apr 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 28, 2024
@dasJ dasJ requested a review from mweinelt May 23, 2024 20:17
@Scriptkiddi
Copy link
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@Scriptkiddi merge not permitted (#305350):
pkgs/development/python-modules/bitvector-for-humans/default.nix is not in pkgs/by-name/
pkgs/development/python-modules/busylight-for-humans/default.nix is not in pkgs/by-name/
pkgs/top-level/python-packages.nix is not in pkgs/by-name/

@0x4A6F
Copy link
Member

0x4A6F commented Jul 17, 2024

Could you also utilize busylight udev-rules to generate these udev Rules and provide it from this package?

@Conni2461 Conni2461 requested a review from natsukium as a code owner July 17, 2024 14:59
@Conni2461 Conni2461 changed the title python312Packages.busylight-for-humans: init at 0.28.0 python312Packages.busylight-for-humans: init at 0.32.0 Jul 17, 2024
@ofborg ofborg bot requested a review from dasJ July 17, 2024 16:01
@dasJ dasJ requested a review from mweinelt July 22, 2024 09:57
@0x4A6F 0x4A6F merged commit af81d1b into NixOS:master Jul 22, 2024
26 checks passed
@Conni2461 Conni2461 deleted the init/busylight branch July 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants