Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcachefs-tools: 1.4.1 -> 1.7.0 #304761

Merged
merged 3 commits into from
May 4, 2024
Merged

bcachefs-tools: 1.4.1 -> 1.7.0 #304761

merged 3 commits into from
May 4, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 17, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Pinging maintainers: @davidak @Madouura

Add a 👍 reaction to pull requests you find important.

@JohnRTitor JohnRTitor requested review from Mic92, Madouura and alyssais and removed request for Madouura April 17, 2024 10:15
@ofborg ofborg bot requested a review from davidak April 17, 2024 10:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 17, 2024
@JohnRTitor JohnRTitor force-pushed the bcachefs-tools branch 2 times, most recently from 69cf973 to 757e269 Compare April 17, 2024 16:09
@JohnRTitor JohnRTitor force-pushed the bcachefs-tools branch 3 times, most recently from 79bf7a6 to 81bc6f1 Compare April 18, 2024 18:38
@JohnRTitor
Copy link
Contributor Author

@ofborg build bcachefs-tools

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 23, 2024 •
edited
Loading

@Mic92 @alyssais is this ready to be approved? Latest bcachefs fixes and features also depend on bcachefs-tools package. So would love it if this could be merged

@alyssais
Copy link
Member

Please squash the latest commit into the update, so there's not an intermediate point where it's using IFD.

@JohnRTitor
Copy link
Contributor Author

@alyssais is this fine now? I decided to keep the last two commits separately, for obvious reasons.

@JohnRTitor JohnRTitor force-pushed the bcachefs-tools branch 2 times, most recently from 583830e to a525c54 Compare April 24, 2024 12:38
@alyssais
Copy link
Member

Test failure on x86_64-linux should probably be investigated. Is it just racy perhaps?

@JohnRTitor
Copy link
Contributor Author

Test failure on x86_64-linux should probably be investigated. Is it just racy perhaps?

When I ran the test locally it did not actually "fail", it tested everything including in a VM, but then it took a lot of time at the finishing stage, leading to the timeout.

@JohnRTitor JohnRTitor requested a review from alyssais April 30, 2024 05:19
@JohnRTitor
Copy link
Contributor Author

@Mic92 @alyssais do I need to make any other changes or is this ready to be merged?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 1, 2024
@onny
Copy link
Contributor

onny commented May 1, 2024

Result of nixpkgs-review pr 304761 run on x86_64-linux 1

1 package built:
  • bcachefs-tools

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3871

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 3, 2024
@JohnRTitor JohnRTitor requested a review from Aleksanaa May 4, 2024 03:45
@onny onny merged commit 25be8f7 into NixOS:master May 4, 2024
27 checks passed
@JohnRTitor JohnRTitor deleted the bcachefs-tools branch May 4, 2024 07:52
@onny
Copy link
Contributor

onny commented May 4, 2024

Thank you!

@jezcope jezcope mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@alyssais alyssais alyssais approved these changes

@onny onny onny approved these changes

@Madouura Madouura Awaiting requested review from Madouura

@davidak davidak Awaiting requested review from davidak

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
Bcachefs
Status: Done
24.05 Blockers
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnRTitor @alyssais @onny @nixos-discourse @Mic92 @wegank