libjxl: build gdk-pixbuf loader and thumbnailer #299988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2024
|
I'm building on top of the gnome-46 branch together with 269563 to test this. Thanks! |
zzzsyyy
force-pushed
the
libjxl_gdk-pixbuf
branch
from
ef5d99f to
966d04c
Compare
|
Works for me. @jtojnar I think I understand why there would be a preference for #153275 to land, but this seems not too dissimilar to the way we have libavif support, and is a blocker for 46 since about half the default wallpapers are jxl - clearly as a push for improving support. Could you give this a quick review of your own please, if you have the time? |
jtojnar
reviewed
Mar 29, 2024
| , zlib | ||
| , asciidoc | ||
| , graphviz | ||
| , doxygen | ||
| , python3 | ||
| }: | ||
|
|
||
| let | ||
| loadersPath = "${gdk-pixbuf.binaryDir}/jxl-loaders.cache"; |
There was a problem hiding this comment.
Maybe also include the version number to make chance of conflict even lower but this looks good to me.
|
As ofborg is complaining (and having compared with the commit I built locally), |
zzzsyyy
force-pushed
the
libjxl_gdk-pixbuf
branch
from
966d04c to
319f05e
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Supersedes #269570
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.