handbrake: 1.6.1 -> 1.7.3

[uninsane]

Description of changes

• fixes existing build break
• upstream changelogs: https://github.com/HandBrake/HandBrake/releases
  • gtk component is ported from autotools to meson
  • upstream mentions a new library, libdovi: i haven't acted on this; seems to be optional
• tested on x86_64-linux:
  • nix build '.#handbrake.tests.basic-conversion'
  • checked that both the gui ('.#handbrake') and headless (useGtk = false) versions build
  • transcoded a short H.264 video through the GUI
  • did not test darwin build

Closes #268104.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[khaneliman]

Result of nixpkgs-review pr 297984 run on aarch64-darwin 1

1 package failed to build:

• handbrake

[khaneliman]

Looks like darwin requires xcrun added to nativeBuildInputs.
Something like this probably.

++ lib.optionals (stdenv.isDarwin) [
    xcbuild.xcrun
  ]

EDIT: looks like it needs more. i'll try and fix it up for darwin and paste my patch here for you.

xcrun metal -O2 -std=macos-metal2.4 -c -frecord-sources ../libhb/platform/macosx/shaders/bwdif_vt.metal -o libhb/platform/macosx/shaders/bwdif_vt.air;
       > /nix/store/hbxknmypkd2lb0az1mvalxv99qs6yk2w-xcodebuild-0.1.2-pre/bin/xcrun: line 42: exec: metal: not found

[wegank]

If metal is required for the build, this means that upstream now has Xcode as a non-free dependency, so the package should be marked as broken on darwin.

[SuperSandro2000]

Isn't the default standard ffmpeg not enough? And if so why?

[bachp]

See #271863 for context

[uninsane]

here's the commit which switched Handbrake to ffmpeg-full. the explanation was:

FFMpeg-full has more codecs/containers for input and more processing possibilities, which seems sane for the rich video transcoder.

i could test a build with stock ffmpeg if you'd like to revisit this, but i don't have any test suite to judge the practical effects of such a change.