zenergy: init at 0-unstable-2024-10-10 #297598
Conversation
|
I apologize if I missed something in advance, first time contributing to the repository! I am a little confused though with the testing and release note markdown, for the testing I couldn't find an example of a kernel module being tested, if it's even possible with the suite available; whereas the markdown file, it implies that not all additions will be covered, so would this PR be applicable still? Not quite sure. |
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
| installPhase = '' | ||
| make modules_install KDIR=${kernelDirectory} | ||
| ''; |
There was a problem hiding this comment.
It should be enough to set makeTarget and makeFlags like already done
There was a problem hiding this comment.
I searched in the repository for examples and tried to replicate, but in the installPhase the KDIR environment wasn't set on top of not running modules_install with makeTargets = [ "modules_install" ].
Am I missing something?
There was a problem hiding this comment.
@SuperSandro2000 can you also give me an update on this?
There was a problem hiding this comment.
installTargets = [ "modules_install" ]; works
There was a problem hiding this comment.
Thank you for the heads-up! Can't believe I hadn't noticed that in the docs.
If you are doing the change on top of nixos-unstable, you can just rebuild your system with it and try to use the kernel module like normally done. |
|
I've been using that kernel module locally since the PR has been open, so I can attest that it's in working condition! I'll be adjusting for the review ASAP. o7 |
github-actions
bot
added
the
8.has: maintainer-list (update)
SuperSandro2000
changed the title
wegank
added
the
2.status: merge conflict
wizardlink
changed the title
ofborg
bot
removed
the
2.status: merge conflict
Description of changes
Adds a new kernel module,
zenergy, this is necessary for accessing CPU power draw data without root permission, specifically MangoHud requires it to be able to show the user their CPU power draw.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.