Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modrinth-app: init at 0.7.1 #289149

Merged
merged 1 commit into from
May 17, 2024
Merged

modrinth-app: init at 0.7.1 #289149

merged 1 commit into from
May 17, 2024
+6,974 −0

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Feb 15, 2024

Description of changes

the modrinth app is a unique, open source minecraft launcher that allows you to play your favorite mods, and keep them up to date, all in one neat little package

it is marked as unfreeRedistributable due to the assets being used. it can also compile on aarch64, however the launcher itself doesn't support it yet

fixes #247468

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo mentioned this pull request Feb 15, 2024
Open
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 15, 2024
@getchoo
Copy link
Member Author

getchoo commented Feb 15, 2024

almost forgot: i'm not really sure how we are meant to handle wrappers (a la prismlauncher) in the new by-name scheme. let me know if my guess was wrong :p

@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 44886d7 to 0d8f4c3 Compare February 15, 2024 23:25
This was referenced Feb 16, 2024
Closed
Merged
@Alanazane
Copy link

Thanks for doing this!
Manually tested and was successfully able to install mods/launch Minecraft 🎉

Result of nixpkgs-review pr 289149 run on x86_64-linux 1

2 packages built:
  • modrinth-app
  • modrinth-app-unwrapped

@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 0d8f4c3 to 5266984 Compare March 5, 2024 02:44
@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 5266984 to 76a3abb Compare March 17, 2024 11:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3654

quantenzitrone
quantenzitrone approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@quantenzitrone quantenzitrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good; ofborg is happy; Alanazane can successfully play Minecraft with it 👍

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 20, 2024
SuperSandro2000
SuperSandro2000 reviewed Mar 23, 2024
View reviewed changes
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mo/modrinth-app/package.nix Outdated Show resolved Hide resolved
@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 76a3abb to 304ae01 Compare March 24, 2024 21:44
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 24, 2024
@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 304ae01 to 5c5762e Compare April 8, 2024 12:14
@getchoo
Copy link
Member Author

getchoo commented Apr 8, 2024

fixed building on darwin

@getchoo getchoo mentioned this pull request Apr 11, 2024
Closed
@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 5c5762e to abdd95c Compare April 24, 2024 23:56
@getchoo getchoo changed the title modrinth-app: init at 0.6.3 modrinth-app: init at 0.7.1 Apr 25, 2024
@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from abdd95c to 8263550 Compare May 5, 2024 00:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3881

@Scrumplex
Copy link
Member

When rebased onto master, this fails to build because of #307077

@getchoo getchoo force-pushed the pkgs/modrinth-app/init branch from 8263550 to d043810 Compare May 8, 2024 20:33
@getchoo
Copy link
Member Author

getchoo commented May 8, 2024

When rebased onto master, this fails to build because of #307077

thanks for catching this :)

@SuperSandro2000 SuperSandro2000 merged commit 4e07ded into NixOS:master May 17, 2024
24 checks passed
@getchoo getchoo deleted the pkgs/modrinth-app/init branch May 18, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@quantenzitrone quantenzitrone quantenzitrone approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: modrinth-app
7 participants
@getchoo @Alanazane @nixos-discourse @Scrumplex @SuperSandro2000 @quantenzitrone @wegank