Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for Typespeed game #2876

Merged
merged 13 commits into from
Jun 9, 2014
Merged

Add package for Typespeed game #2876

merged 13 commits into from
Jun 9, 2014

Conversation

auntieNeo
Copy link
Contributor

I packaged the classic Typespeed typing game for Nix. By default, typespeed stores high score files and such in /var and /etc, which is problematic in Nix. I wrote a rather lengthy patch that creates a ~/.typespeed directory with ~/.typespeed/score and ~/.typespeed/config when typespeed is started.

I wasn't sure how I should add myself as a package maintainer, so I left that out for now.

@7c6f434c
Copy link
Member

7c6f434c commented Jun 9, 2014

I think if you add a significant patch, it is better to add yourself as a maintainer.

Also, the preferred way of listing licenses is via stdenv.lib.licenses.

@auntieNeo
Copy link
Contributor Author

Alright, I added myself as a maintainer and set the license as you suggested.

7c6f434c added a commit that referenced this pull request Jun 9, 2014
Add package for Typespeed game
@7c6f434c 7c6f434c merged commit 4b68be6 into NixOS:master Jun 9, 2014
@Fuuzetsu
Copy link
Member

Fuuzetsu commented Jun 9, 2014

It's probably also better to squash your work into few coherent commits after you're done hacking on it: no need for everyone to see files added by mistake &c

@auntieNeo auntieNeo deleted the typespeed branch June 13, 2014 21:01
@infinisil infinisil mentioned this pull request Mar 15, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants