Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picard: set path for localedir build option #284050

Merged
merged 1 commit into from
Feb 22, 2024
Merged

picard: set path for localedir build option #284050

merged 1 commit into from
Feb 22, 2024

Conversation

Elserjo
Copy link
Contributor

@Elserjo Elserjo commented Jan 26, 2024

Description of changes

All locales have already been installed, but without "localedir" build option picard will look at default "/usr/share/locale" path. For example, some debug info:

D: 19:20:42,618 i18n.setup_gettext:154: Trying locales: []
D: 19:20:42,618 i18n.set_locale_from_env:74: Setting locale from env: 'ru_RU.UTF-8'
D: 19:20:42,618 i18n.setup_gettext:171: Using locale: 'ru_RU.UTF-8'
D: 19:20:42,618 i18n._load_translation:118: Loading gettext translation for picard, localedir='/usr/share/locale', language='ru_RU.UTF-8'
D: 19:20:42,619 i18n._load_translation:121: [Errno 2] No translation file found for domain: 'picard'
D: 19:20:42,619 i18n._load_translation:118: Loading gettext translation for picard-attributes, localedir='/usr/share/locale', language='ru_RU.UTF-8'
D: 19:20:42,619 i18n._load_translation:121: [Errno 2] No translation file found for domain: 'picard-attributes'
D: 19:20:42,619 i18n._load_translation:118: Loading gettext translation for picard-constants, localedir='/usr/share/locale', language='ru_RU.UTF-8'
D: 19:20:42,619 i18n._load_translation:121: [Errno 2] No translation file found for domain: 'picard-constants'
D: 19:20:42,619 i18n._load_translation:118: Loading gettext translation for picard-countries, localedir='/usr/share/locale', language='ru_RU.UTF-8'
D: 19:20:42,619 i18n._load_translation:121: [Errno 2] No translation file found for domain: 'picard-countries'

with localedir:

D: 19:24:25,944 i18n.setup_gettext:154: Trying locales: []
D: 19:24:25,944 i18n.set_locale_from_env:74: Setting locale from env: 'ru_RU.UTF-8'
D: 19:24:25,944 i18n.setup_gettext:171: Using locale: 'ru_RU.UTF-8'
D: 19:24:25,945 i18n._load_translation:118: Loading gettext translation for picard, localedir='/nix/store/dr04dzy2lzgy76ilrjj1ij84y1b9ki88-picard-2.10/share/locale', language='ru_RU.UTF-8'
D: 19:24:25,946 i18n._load_translation:118: Loading gettext translation for picard-attributes, localedir='/nix/store/dr04dzy2lzgy76ilrjj1ij84y1b9ki88-picard-2.10/share/locale', language='ru_RU.UTF-8'
D: 19:24:25,947 i18n._load_translation:118: Loading gettext translation for picard-constants, localedir='/nix/store/dr04dzy2lzgy76ilrjj1ij84y1b9ki88-picard-2.10/share/locale', language='ru_RU.UTF-8'
D: 19:24:25,947 i18n._load_translation:118: Loading gettext translation for picard-countries, localedir='/nix/store/dr04dzy2lzgy76ilrjj1ij84y1b9k

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from ehmry January 26, 2024 16:49
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3496

@SuperSandro2000 SuperSandro2000 merged commit bb84ac6 into NixOS:master Feb 22, 2024
27 checks passed
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Nov 1, 2024
@wolfgangwalther
picard: set localedir without relying on bash eval
1d1b680 
To be able to remove the bash-eval behavior for setupPyGlobalFlags, we
change $out to use placeholder "out" instead.

Confirmed that the locales are still loaded from the correct path as
demonstrated in NixOS#284050.
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Nov 2, 2024
@wolfgangwalther
picard: set localedir without relying on bash eval
1f477ad 
To be able to remove the bash-eval behavior for setupPyGlobalFlags, we
change $out to use placeholder "out" instead.

Confirmed that the locales are still loaded from the correct path as
demonstrated in NixOS#284050.
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Nov 3, 2024
@wolfgangwalther
picard: set localedir without relying on bash eval
edf4aa6 
To be able to remove the bash-eval behavior for setupPyGlobalFlags, we
change $out to use placeholder "out" instead.

Confirmed that the locales are still loaded from the correct path as
demonstrated in NixOS#284050.
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Nov 9, 2024
@wolfgangwalther
picard: set localedir without relying on bash eval
529cfcb 
To be able to remove the bash-eval behavior for setupPyGlobalFlags, we
change $out to use placeholder "out" instead.

Confirmed that the locales are still loaded from the correct path as
demonstrated in NixOS#284050.
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Nov 12, 2024
@wolfgangwalther
picard: set localedir without relying on bash eval
23b7dc8 
To be able to remove the bash-eval behavior for setupPyGlobalFlags, we
change $out to use placeholder "out" instead.

Confirmed that the locales are still loaded from the correct path as
demonstrated in NixOS#284050.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elserjo @nixos-discourse @SuperSandro2000