-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fira-math: init at 0.3.4 #278225
fira-math: init at 0.3.4 #278225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is there much value in packaging both the stable and unstable versions? Maybe we should keep just the unstable version.
a1d4673
to
ba45da3
Compare
Thanks @nevivurn for the review. I removed the stable package and applied your revisions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 278225
run on x86_64-linux 1
1 package built:
- fira-math
1e0a2a9
to
2a6595c
Compare
Co-authored-by: Yongun Seong <[email protected]> Co-authored-by: Weijia Wang <[email protected]>
2a6595c
to
c7b66c7
Compare
Description of changes
Add Fira Math, a Fira Sans extension with Unicode math support. I added a
fira-math-next
package to provide an up to date version since it's been a while since a new version has been released.Notably, the up-to-date version has more font variation.
I originally created #183108, but it was closed because I deleted the forked repository.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.