Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fira-math: init at 0.3.4 #278225

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

loicreynier
Copy link
Contributor

@loicreynier loicreynier commented Jan 2, 2024

Description of changes

Add Fira Math, a Fira Sans extension with Unicode math support. I added a fira-math-next package to provide an up to date version since it's been a while since a new version has been released.
Notably, the up-to-date version has more font variation.

I originally created #183108, but it was closed because I deleted the forked repository.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 2, 2024
Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is there much value in packaging both the stable and unstable versions? Maybe we should keep just the unstable version.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/fira-math/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/fira-math/next.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/fira-math/next.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/fira-math/default.nix Outdated Show resolved Hide resolved
@loicreynier loicreynier force-pushed the fira-math-init-at-0.3.4 branch 3 times, most recently from a1d4673 to ba45da3 Compare January 3, 2024 19:38
@loicreynier
Copy link
Contributor Author

Thanks @nevivurn for the review. I removed the stable package and applied your revisions.

Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 278225 run on x86_64-linux 1

1 package built:
  • fira-math

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 7, 2024
@wegank wegank force-pushed the fira-math-init-at-0.3.4 branch 2 times, most recently from 1e0a2a9 to 2a6595c Compare January 7, 2024 19:47
Co-authored-by: Yongun Seong <[email protected]>
Co-authored-by: Weijia Wang <[email protected]>
@wegank wegank force-pushed the fira-math-init-at-0.3.4 branch from 2a6595c to c7b66c7 Compare January 7, 2024 19:48
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 7, 2024
@wegank wegank merged commit 4471857 into NixOS:master Jan 19, 2024
23 checks passed
@loicreynier loicreynier deleted the fira-math-init-at-0.3.4 branch January 19, 2024 09:16
loicreynier added a commit to loicreynier/nixpkgs-lor that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants