git-ftp: init at 1.4.0 #27177
Merged
git-ftp: init at 1.4.0 #27177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
Jul 7, 2017
| src = fetchFromGitHub { | ||
| owner = "git-ftp"; | ||
| repo = "git-ftp"; | ||
| rev = "2c22f5118d61070449532a524db77bf810c13b97"; |
There was a problem hiding this comment.
Please use the release tag instead of the revision.
Mic92
reviewed
Jul 7, 2017
| src = fetchFromGitHub { | ||
| owner = "git-ftp"; | ||
| repo = "git-ftp"; | ||
| rev = "2c22f5118d61070449532a524db77bf810c13b97"; |
| make install${lib.optionalString (!stdenv.isDarwin) "-all"} prefix=$out | ||
| ''; | ||
|
|
||
| buildInputs = lib.optionals (!stdenv.isDarwin) [pandoc man-db]; |
There was a problem hiding this comment.
Can you add a comment, why darwin does not support pandoc and man-db here? How is man-db used in the build process?
There was a problem hiding this comment.
man-db builds only on platforms.linux and i thought since there is no man-db there is no point in building the man pages on Darwin.
There was a problem hiding this comment.
afaik manpages are still usable on darwin.
| }; | ||
|
|
||
| # fixupPhase is needed for manpages | ||
| phases = ["unpackPhase" "installPhase" "fixupPhase"]; |
There was a problem hiding this comment.
We usually prefer dontBuild = true; over overriding phases.
|
Thanks! |
|
thank you! |
timokau
added a commit
to timokau/nixpkgs
that referenced
this pull request
Apr 26, 2018
27177 was merged but not backported to 2.7. There is currently an open PR for 25750.
timokau
added a commit
to timokau/nixpkgs
that referenced
this pull request
Apr 26, 2018
27177 was merged but not backported to 2.7. There is currently an open PR for 25750.
timokau
added a commit
to timokau/nixpkgs
that referenced
this pull request
May 28, 2018
27177 was merged but not backported to 2.7. There is currently an open PR for 25750.
FRidh
pushed a commit
that referenced
this pull request
May 28, 2018
27177 was merged but not backported to 2.7. There is currently an open PR for 25750.
FRidh
pushed a commit
that referenced
this pull request
Jun 2, 2018
27177 was merged but not backported to 2.7. There is currently an open PR for 25750.
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
git-ftp is a nice tool when developing for web and hosting is not under your control.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)