arrow-cpp: fix crash in tests on x86_64-darwin #265395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 10.12 Libsystem is not located as a sub-attribute of `darwin.apple_sdk_10_12`. This will be fixed as part of the SDK changes planned for post-23.11. In the meantime, special case it so the adapter can be used to change the deployment target.
abseil-cpp builds with the default SDK, which can break dependent packages that require a different SDK version to build. Don’t propagate the CoreFoundation framework path and rely on nixpkgs to provide it instead. The line can’t be dropped because otherwise abseil-cpp will fail to build (due to missing symbols).
Setting the deployment target to 10.13 is needed apparently for compatibility with GRPC. Otherwise, several arrow-cpp tests crash.
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 0
13 tasks
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
arrow-cpp crash fixes on x86_64-darwin for staging-next #263535.
The crash was happening GRPC due apparently the differing deployment targets. I cherry-picked #264503 as part of the troubleshooting and have opted to leave it included in the PR to avoid having to wait for another arrow-cpp rebuild.
I tested that arrow-cpp built on x86_64-darwin, but arrow-s3fs-test failed for me due to #265102. It is expected arrow-cpp should build successfully on Hydra.
Closes #264503.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)