Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.torchvision-bin: fix aarch64-darwin build #244716

Merged
merged 1 commit into from
Jul 22, 2023
Merged

python3Packages.torchvision-bin: fix aarch64-darwin build #244716

merged 1 commit into from
Jul 22, 2023

Conversation

samuela
Copy link
Member

@samuela samuela commented Jul 21, 2023 •
edited
Loading

Description of changes

Turns out that the build on aarch64-darwin was broken for a few reasons.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 21, 2023
@samuela samuela force-pushed the samuela/torchvision-bin branch from 9cffe63 to 3080e7c Compare July 21, 2023 20:31
@samuela samuela mentioned this pull request Jul 21, 2023
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 21, 2023
@marsam marsam merged commit b12c502 into NixOS:master Jul 22, 2023
@samuela samuela deleted the samuela/torchvision-bin branch July 24, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@junjihashimoto junjihashimoto Awaiting requested review from junjihashimoto

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuela @GaetanLepage @marsam