Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.ariadne: fix build #234702

Merged
merged 1 commit into from
May 29, 2023
Merged

python310Packages.ariadne: fix build #234702

merged 1 commit into from
May 29, 2023

Conversation

mweinelt
Copy link
Member

Fix the format and disable tests that require an unpackaged dependency.

ZHF #230712

Noticed in #234671 (comment)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mweinelt
python310Packages.ariadne: fix build
e39ea12 
Fix the format and disable tests that require an unpackaged dependency.
@mweinelt mweinelt added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign and removed 6.topic: python labels May 28, 2023
@ofborg ofborg bot requested a review from samuela May 28, 2023 23:55
@AndersonTorres AndersonTorres merged commit 8a02904 into NixOS:master May 29, 2023
@github-actions github-actions bot mentioned this pull request May 29, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@mweinelt mweinelt deleted the ariadne-fix-format branch May 29, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela Awaiting requested review from samuela

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @AndersonTorres