Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsl-lite: fix tests #230849

Merged
merged 1 commit into from
May 9, 2023
Merged

gsl-lite: fix tests #230849

merged 1 commit into from
May 9, 2023

Conversation

azahi
Copy link
Member

@azahi azahi commented May 9, 2023

Description of changes

ZHF: #230712

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@azahi azahi marked this pull request as draft May 9, 2023 10:12
@azahi azahi marked this pull request as ready for review May 9, 2023 10:52
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 ofborg-internal-error Ofborg encountered an error labels May 9, 2023
@mweinelt mweinelt removed the ofborg-internal-error Ofborg encountered an error label May 9, 2023
@SuperSandro2000 SuperSandro2000 added the ofborg-internal-error Ofborg encountered an error label May 9, 2023
@SuperSandro2000
Copy link
Member

@ofborg eval

@wegank wegank merged commit 7f57da3 into NixOS:master May 9, 2023
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azahi @SuperSandro2000 @mweinelt @wegank @cole-h