Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.lambdasoup: 0.7.3 → 1.0.0 #230755

Merged
merged 1 commit into from
May 9, 2023
Merged

ocamlPackages.lambdasoup: 0.7.3 → 1.0.0 #230755

merged 1 commit into from
May 9, 2023

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 8, 2023

Description of changes

Support for OCaml 5.0: https://github.com/aantron/lambdasoup/releases/tag/1.0.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels May 8, 2023
@vbgl vbgl requested review from romildo and ulrikstrid as code owners May 8, 2023 18:58
@vbgl vbgl mentioned this pull request May 8, 2023
Closed
12 tasks
@ulrikstrid
Copy link
Member

Result of nixpkgs-review pr 230755 run on x86_64-linux 1

1 package built:
  • soupault

@ulrikstrid ulrikstrid merged commit e42efb4 into NixOS:master May 9, 2023
@vbgl vbgl deleted the ocaml-lambdasoup-1.0.0 branch May 9, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @ulrikstrid