Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moolticute: 1.00.1 -> 1.01.0 | Add hughobrien as maintainer #215034

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

hughobrien
Copy link
Contributor

@hughobrien hughobrien commented Feb 7, 2023

Description of changes

Upstream Release Notes

This package was previously broken, original maintainer seems absent so putting myself forward. Prior fixes I have made

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@hughobrien hughobrien changed the title moolticute: 1.00.1 -> 1.01.0. add hughobrien as maintainer moolticute: 1.00.1 -> 1.01.0 | Add hughobrien as maintainer Feb 7, 2023
@ofborg ofborg bot requested a review from kirikaza February 7, 2023 02:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 7, 2023
@tomodachi94
Copy link
Member

@hughobrien There should be 3 separate commits:

  • 1 for version bump
  • 1 for adding yourself to global maintainers
  • 1 for adding yourself to this package's maintainers.

@hughobrien
Copy link
Contributor Author

Thank you, I've corrected this.

@wegank wegank merged commit 766e64e into NixOS:master Feb 7, 2023
@hughobrien hughobrien deleted the moolticute-v1.01.0 branch February 7, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants