Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timescaledb: 2.9.1 -> 2.9.2 #212467

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

typetetris
Copy link
Contributor

Description of changes

timescaledb patch version upgrade

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Cherry picked this onto #186276 and ran the nixos test there for postgresql 15.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2023
@ckiee
Copy link
Member

ckiee commented Jan 24, 2023

Result of nixpkgs-review pr 212467 run on x86_64-linux 1

Human: nixpkgs-review didn't work right, but /nix/store/0byc8n9py860pfym7gvbsi5y0bzfb17z-timescaledb-2.9.2 builds fine.

Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't run:
machine # [ 26.600244] postgres[975]: [975] FATAL: could not load library "/nix/store/1q1py7cbqkizxlpimk6mklka5plwjrd2-postgresql-and-plugins-13.9/lib/timescaledb.so": /nix/store/1q1py7cbqkizxlpimk6mklka5plwjrd2-postgresql-and-plugins-13.9/lib/timescaledb.so: undefined symbol: errstart_cold

Diff in //nixpkgs/nixos/tests/postgresql.nix to test:

        services.postgresql = {
          enable = true;
          package = postgresql-package;
+         extraPlugins = [ pkgs.timescaledb ];
+         settings.shared_preload_libraries = "timescaledb";
        };

P.S. It was already broken before, but with undefined symbol: table_open instead, so something has probably changed.

@typetetris typetetris force-pushed the feature/timescaledb-2.9.2 branch from fa258ea to 5ed22cc Compare January 25, 2023 06:57
Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be merging after I apply this formatting diff:

index 399d2822d29..7c9e8fa6959 100644
--- a/pkgs/servers/sql/postgresql/ext/timescaledb.nix
+++ b/pkgs/servers/sql/postgresql/ext/timescaledb.nix
@@ -2,13 +2,12 @@
 
 # # To enable on NixOS:
 # config.services.postgresql = let
-#   postgresql_package = pkgs.postgresql;
 #   # The postgresql pkgs has to be taken from the
 #   # postgresql package used, so the extensions
 #   # are built for the correct postgresql version.
-#   postgresql_packages = postgresql_package.pkgs;
+#   postgresqlPackages = config.services.postgresql.package.pkgs;
 # in {
-#   extraPlugins = with postgresql_packages; [ timescaledb ];
+#   extraPlugins = with postgresqlPackages; [ timescaledb ];
 #   settings.shared_preload_libraries = "timescaledb";
 # }

Thanks for your contributions (:

@ckiee ckiee force-pushed the feature/timescaledb-2.9.2 branch from 5ed22cc to 8e76987 Compare January 25, 2023 14:43
@typetetris
Copy link
Contributor Author

LTGM

What needs to happen, so this gets merged?

@ckiee
Copy link
Member

ckiee commented Jan 26, 2023

Oh, nothing more. I was just waiting for CI to pass and then closed the tab before I checked it again. :P

@ckiee ckiee merged commit 16d84e9 into NixOS:master Jan 26, 2023
@typetetris typetetris deleted the feature/timescaledb-2.9.2 branch January 26, 2023 08:38
@typetetris
Copy link
Contributor Author

Oh, nothing more. I was just waiting for CI to pass and then closed the tab before I checked it again. :P

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants