-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timescaledb: 2.9.1 -> 2.9.2 #212467
timescaledb: 2.9.1 -> 2.9.2 #212467
Conversation
Result of Human: nixpkgs-review didn't work right, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't run:
machine # [ 26.600244] postgres[975]: [975] FATAL: could not load library "/nix/store/1q1py7cbqkizxlpimk6mklka5plwjrd2-postgresql-and-plugins-13.9/lib/timescaledb.so": /nix/store/1q1py7cbqkizxlpimk6mklka5plwjrd2-postgresql-and-plugins-13.9/lib/timescaledb.so: undefined symbol: errstart_cold
Diff in //nixpkgs/nixos/tests/postgresql.nix
to test:
services.postgresql = {
enable = true;
package = postgresql-package;
+ extraPlugins = [ pkgs.timescaledb ];
+ settings.shared_preload_libraries = "timescaledb";
};
P.S. It was already broken before, but with undefined symbol: table_open
instead, so something has probably changed.
fa258ea
to
5ed22cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be merging after I apply this formatting diff:
index 399d2822d29..7c9e8fa6959 100644
--- a/pkgs/servers/sql/postgresql/ext/timescaledb.nix
+++ b/pkgs/servers/sql/postgresql/ext/timescaledb.nix
@@ -2,13 +2,12 @@
# # To enable on NixOS:
# config.services.postgresql = let
-# postgresql_package = pkgs.postgresql;
# # The postgresql pkgs has to be taken from the
# # postgresql package used, so the extensions
# # are built for the correct postgresql version.
-# postgresql_packages = postgresql_package.pkgs;
+# postgresqlPackages = config.services.postgresql.package.pkgs;
# in {
-# extraPlugins = with postgresql_packages; [ timescaledb ];
+# extraPlugins = with postgresqlPackages; [ timescaledb ];
# settings.shared_preload_libraries = "timescaledb";
# }
Thanks for your contributions (:
5ed22cc
to
8e76987
Compare
LTGM What needs to happen, so this gets merged? |
Oh, nothing more. I was just waiting for CI to pass and then closed the tab before I checked it again. :P |
Thank you! |
Description of changes
timescaledb patch version upgrade
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesCherry picked this onto #186276 and ran the nixos test there for postgresql 15.