Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipewire: 0.3.63 -> 0.3.63 #207895

Merged
merged 1 commit into from
Jan 3, 2023
Merged

pipewire: 0.3.63 -> 0.3.63 #207895

merged 1 commit into from
Jan 3, 2023

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for pipewire is: "Server and user space API to deal with multimedia pipelines"

meta.homepage for pipewire is: "https://pipewire.org/"

meta.changelog for pipewire is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 0.3.63 with grep in /nix/store/0hdlg94l91r3x6wi6sj7izaiafh7vlyh-pipewire-0.3.63
  • found 0.3.63 in filename of file in /nix/store/0hdlg94l91r3x6wi6sj7izaiafh7vlyh-pipewire-0.3.63

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
nixos-install-tools
tests.nixos-functions.nixos-test
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0hdlg94l91r3x6wi6sj7izaiafh7vlyh-pipewire-0.3.63 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pipewire https://github.com/r-ryantm/nixpkgs/archive/0fe0ee997ff8914b198f305f48f5de8695e8601d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0hdlg94l91r3x6wi6sj7izaiafh7vlyh-pipewire-0.3.63
ls -la /nix/store/0hdlg94l91r3x6wi6sj7izaiafh7vlyh-pipewire-0.3.63/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • nixos-install-tools

Maintainer pings

cc @jtojnar @Kranzes for testing.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 27, 2022
@bjornfor
Copy link
Contributor

@r-ryantm @ryantm: what happened here? Look at commit.

@ryantm
Copy link
Member

ryantm commented Dec 30, 2022

@bjornfor interesting. I'm guessing that's what the update script does when you run it.

@jtojnar
Copy link
Member

jtojnar commented Dec 30, 2022

Right, looks like the person that last updated pipewire did not use the update script so the module changes were omitted. cc @K900

@K900
Copy link
Contributor

K900 commented Dec 30, 2022

Huh, I was sure I committed those. Anyway, I've been looking at how we can avoid doing the thing we're currently doing with the config files, because it doesn't really work the way you expect anyway...

@K900 K900 merged commit f7f8f2b into NixOS:master Jan 3, 2023
@r-ryantm r-ryantm deleted the auto-update/pipewire branch January 6, 2023 06:26
@eyJhb
Copy link
Member

eyJhb commented Jan 10, 2023

Is there any good ways to disable/remove libpipewire-module-x11-bell? I can't seem to find any, and unsure about the best way to disable it using NixOS module system.
Running i3wm, and the bell is just everywhere...

Currently I've ended up reverting this commit in my local checkout of nixpkgs.
Guessing that "soon" there will be others with the same complaint, as it is truly, unbearable.

@turboMaCk
Copy link
Member

Debian added an option to disable it according to this tweet

Imo we should do the same. Otherwise I might switch to windows.

@K900
Copy link
Contributor

K900 commented Mar 14, 2023

That is in no way Debian specific and you can already set that option in your Pipewire config file.

@turboMaCk
Copy link
Member

turboMaCk commented Mar 14, 2023

yes I will for now use services.pipewire.config.pipewire to set this. Though imo we should define extra option on pipewire service for this purpose which is discoverable via https://search.nixos.org/options?channel=22.11&from=0&size=50&sort=relevance&type=packages&query=pipewire.config like services.pipewire.bell. At the moment it's really not trivial to find what is the thing that needs to be configured (pipewire) and how it could be done. You need to do forcensic analysis of your whole software stack to find this.

@K900
Copy link
Contributor

K900 commented Mar 14, 2023

services.pipewire.config is probably the wrong place to set this, see #220332. You probably want to create a drop-in file in /etc/pipewire/pipewire.conf.d/foo.conf instead.

@turboMaCk
Copy link
Member

turboMaCk commented Mar 14, 2023

ok this is the right thing. Doesn't matter how you create it:

❯❯❯ cat /etc/pipewire/pipewire.conf.d/99-custom.conf
{
   "context.properties": {
       "module.x11.bell": false 
   }
}

Orginal

So I've read https://gist.github.com/K900/20fb1651d72411e3419d278bb29343ea and https://t.co/AB7Jvf8Lne

did:

$ cat /etc/pipewire/pipewire.conf.d/99-custom.conf
{
   module.x11.bell = false 
}

without success.

If someone figures this out let me know. Unfortunately I don't have time to fiddle with this now since I should have been working on different thing so for now the solution is never to turn on sound on the laptop :D

@eyJhb
Copy link
Member

eyJhb commented Mar 14, 2023

My time to shine! This is how my pipewire config looks (take out the things you don't want), but this just removes the bell, as it was driving me insane as well...

{ config, lib, ... }:

let
  defaultConfig = lib.importJSON (<nixpkgs/nixos/modules/services/desktops/pipewire/daemon/pipewire.conf.json>);

  finalConfig = let
    filteredModules = builtins.filter (v: v.name != "libpipewire-module-x11-bell") defaultConfig."context.modules";
  in defaultConfig // { "context.modules" = filteredModules; };
in {
  # disable sound as it might cause issues
  sound.enable = lib.mkForce false;

  # required to disable pulseaudio 
  hardware.pulseaudio.enable = lib.mkForce false;

  # rtkit is optional but recommended
  security.rtkit.enable = true;

  services.pipewire = {
    enable = true;

    alsa.enable = true;
    alsa.support32Bit = true;
    pulse.enable = true;

    config.pipewire = finalConfig;
  };
}

@K900
Copy link
Contributor

K900 commented Mar 14, 2023

The drop-in needs to be a JSON file, and the value needs to be set in context.properties.

@turboMaCk
Copy link
Member

turboMaCk commented Mar 14, 2023

yeah I already updated with solution hour ago #207895 (comment) that should be hopefully fool proofed.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/mysterious-unstoppable-alert-sounds/26801/3

@rjpcasalino
Copy link
Contributor

rjpcasalino commented Jan 10, 2024

I guess this is part of pulse audio? The docs aren't really clear to me for pipewire and modules and contexts et al https://docs.pipewire.org/page_pulse_module_x11_bell.html - would be nice to have an easy way to set an alert sound when someone isn't using a desktop env like myself but, hey, turning it off works well enough.

@rjpcasalino
Copy link
Contributor

rjpcasalino commented Jan 10, 2024

@eyJhb how can I use the spaceship jazz <nixpkgs/nixos/modules/services/desktops/pipewire/daemon/pipewire.conf.json> if I'm using flakes and don't have a $NIX_PATH? basically how can I load up the config? modulesPath or something? apologizes if this is a silly question to ask here 🙂 ; blah, nvm - I just ended up re enabling channels which would allow <nixpkgs> jazz

@eyJhb
Copy link
Member

eyJhb commented Jan 10, 2024

@eyJhb how can I use the spaceship jazz <nixpkgs/nixos/modules/services/desktops/pipewire/daemon/pipewire.conf.json> if I'm using flakes and don't have a $NIX_PATH? basically how can I load up the config? modulesPath or something? apologizes if this is a silly question to ask here 🙂 ; blah, nvm - I just ended up re enabling channels which would allow <nixpkgs> jazz

Maybe this (untested).

{ config, lib, modulesPath, ... }:

let
  defaultConfig = lib.importJSON (modulesPath + "/services/desktops/pipewire/daemon/pipewire.conf.json");
....

@K900
Copy link
Contributor

K900 commented Jan 10, 2024

This is no longer supported at all. What is your end goal here?

@eyJhb
Copy link
Member

eyJhb commented Jan 10, 2024

Oh true, I completely forgot. I don't even use that anymore.

This is what I currently have in my configuration

environment.etc."pipewire/pipewire.conf.d/99-no-bell.conf".text = ''{"context.properties": {"module.x11.bell": false}}'';

@rjpcasalino
Copy link
Contributor

rjpcasalino commented Jan 10, 2024

ah, I see. I probably can get this done with extraConfig I'd gather. Thank you kindly for the replies, regardless! I just want to set this cleanly in my config. Whereas environment.etc will surely work (thank you, again!) I don't think it's as clean as extraConfig for all its pitfalls.

@K900
Copy link
Contributor

K900 commented Jan 10, 2024

I'm still not sure what you're actually trying to do. Are you trying to enable the bell? Because it's on by default.

@rjpcasalino
Copy link
Contributor

rjpcasalino commented Jan 10, 2024

disable it for now (which I've done) but in future would like to set it to some custom sound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants