Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.51.0 -> 1.52.0 #158816

Merged
merged 1 commit into from
Feb 12, 2022
Merged

matrix-synapse: 1.51.0 -> 1.52.0 #158816

merged 1 commit into from
Feb 12, 2022

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 9, 2022

Motivation for this change

upstream release

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested review from Ma27 and sumnerevans February 9, 2022 19:11
sumnerevans
sumnerevans approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running on my server and works fine.

@K900
Copy link
Contributor

K900 commented Feb 11, 2022

Needs matrix-org/synapse#11969 to build on latest master

@arcnmx
Copy link
Member

arcnmx commented Feb 11, 2022

Needs matrix-org/synapse#11969 to build on latest master

After applying this patch it seems to be running normally here.

@bachp
Copy link
Member

bachp commented Feb 12, 2022

#155546 fixed this too.

bachp
bachp approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #155546 this updated works without issues on my home server.

@K900
Copy link
Contributor

K900 commented Feb 12, 2022

Probably worth replacing with an upstream patch still.

@mweinelt mweinelt merged commit bbeef25 into NixOS:master Feb 12, 2022
@github-actions github-actions bot mentioned this pull request Feb 12, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #159688 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumnerevans sumnerevans sumnerevans approved these changes

@bachp bachp bachp approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@Ralith Ralith Awaiting requested review from Ralith

@dali99 dali99 Awaiting requested review from dali99

@Ekleog Ekleog Awaiting requested review from Ekleog

@fadenb fadenb Awaiting requested review from fadenb

@mjlbach mjlbach Awaiting requested review from mjlbach

@mguentner mguentner Awaiting requested review from mguentner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ajs124 @K900 @arcnmx @bachp @sumnerevans @mweinelt @Ma27